GNOME Bugzilla – Bug 102134
Remove unnecessary markup from glade messages in gnome-system-tools
Last modified: 2010-06-07 21:55:07 UTC
#: interfaces/common.glade.h:10 interfaces/common.glade.in.h:2 msgid "" "<span weight=\"bold\">The platform you are running is not supported by this " "tool.</span>\n" "\n" "If you know for sure that it works like one of the platforms listed below, " "you can select that and continue.\n" "\n" "Note, however, that this might damage the system configuration or downright " "cripple your computer." #: interfaces/common.glade.h:17 interfaces/common.glade.in.h:7 msgid "" "<span weight=\"bold\">To run this tool, you need administrator privileges.</" "span>\n" "\n" "To acquire such privileges, enter your root password below. If you don't\n" "specify a password, you will be unable to modify your system configuration." #: interfaces/runlevel.glade.h:8 interfaces/runlevel.glade.h:12 #: interfaces/runlevel.glade.in.h:1 msgid "<span weight=\"bold\">Description:</span>" #: interfaces/runlevel.glade.h:10 interfaces/runlevel.glade.in.h:4 msgid "<span weight=\"bold\">Script name:</span>" #: interfaces/runlevel.glade.h:11 interfaces/runlevel.glade.in.h:3 msgid "<span weight=\"bold\">Priority:</span>" #: interfaces/runlevel.glade.h:13 interfaces/runlevel.glade.in.h:2 msgid "<span weight=\"bold\">Parameters:</span>" This use of markup inside a message marked for translation is totally unnecessary, and a problem for the translation process. For details, see the problem description in bug 96836. Since this is a glade message, I'll mark it dependant on the glade bug 97061 in the mean time.
Now that the module has migrated to GTKBuilder, this should be done as soon as the minimum GTK+ version will be bumped to 2.15/2.16.
I guess I won't do this for 2.28, but for the next release it should be done - at last!
Created attachment 155983 [details] [review] Remove markup from ui files First untested try. Should be generally ok, I'm worried a bit only about this part in shares.ui: - <property name="label" translatable="yes"><span size="l - <property name="use_markup">True</property> + <property name="label" translatable="yes">Enter password f + <attributes> + <attribute name="weight" value="bold"/> + <attribute name="size" value="1.2"/> + </attributes> I don't know, how can I make that window (smb_password_dialog) appear, so I could not test if this looks good.
Gabor, didn't you try to open it in glade-3? I think you should use the "scale" attribute name instead of "size".
Thanks for working on this, Gabor! Claude, do you think we should update the PO files in the same commit, e.g. by running sed on all of them? Or is there an easier solution? Anyway, that will have to wait for 2.30 to be released.
I think it's better to wait that a 2.30 branch is created before applying this. This is no critical at all. And then, let translators update translations themselves for the next cycle.
Created attachment 156056 [details] [review] Updated patch Ooops, I forgot to checkout master, the previous patch was against 2.28. Also, I changed the size attribute's value to 12000, as seen in users.ui, I hope this is not too big, looked good in Glade. Perhaps just me, but I tried to set scale to 1.2, and Glade rounded it to 1,00, without any visible effect on the size.
Gabor: now that 2.30 is released, please go on and commit this to the master branch. Thanks for your help! I guess there should be a way to avoid translators the burden of updating their strings, something like sed 's/<(/)b>//g' in the po/ directory. Would you give it a try? Else I'll see if I can do this.
I've eventually committed this with many painful hacks to remove as much work as possible on translators' side. Most of old strings are still translated, by removing markup on both sides. I hope this doesn't break anything in the PO files, but the diff seems good, and make update-po works. This was really needed, since adding more work for translators on a project that is reaching end of life is not really helping them! ;-) Commit is fde926.