After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 100553 - Incorrect test on valloc return in gst/cothreads.c
Incorrect test on valloc return in gst/cothreads.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.4.2
Other FreeBSD
: Normal normal
: 0.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2002-12-06 19:54 UTC by Jonathan Irwin
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jonathan Irwin 2002-12-06 19:54:12 UTC 
Causes some apps using multithreaded pipelines to fail with the message
"Could not valloc stack !" on FreeBSD (and presumably any other systems
without posix_memalign).

The following one-line diff against 0.4.2 fixes the problem:

--- gst/cothreads.c.orig        Fri Dec  6 19:40:17 2002
+++ gst/cothreads.c     Sun Dec  1 22:54:17 2002
@@ -550,7 +550,7 @@
   GST_DEBUG (GST_CAT_THREAD, "have  posix_memalign at %p of size %d",
              (void *) *stack, STACK_SIZE);
 #else
-  if ((*stack = valloc (STACK_SIZE)) != 0)
+  if ((*stack = valloc (STACK_SIZE)) == 0)
   {
     g_warning ("Could not valloc stack !\n");
     return FALSE;
Comment 1 Thomas Vander Stichele 2002-12-07 18:45:08 UTC 
commited to cvs