After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626687 - Should support Geolocation, including asking the user for permission to provide the information
Should support Geolocation, including asking the user for permission to provi...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Xan Lopez
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-11 22:24 UTC by Gustavo Noronha (kov)
Modified: 2010-08-24 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (3.83 KB, patch)
2010-08-11 22:26 UTC, Gustavo Noronha (kov)
none Details | Review
proposed patch (4.04 KB, patch)
2010-08-11 22:47 UTC, Gustavo Noronha (kov)
committed Details | Review

Description Gustavo Noronha (kov) 2010-08-11 22:24:15 UTC
SSIA.
Comment 1 Gustavo Noronha (kov) 2010-08-11 22:26:33 UTC
Created attachment 167676 [details] [review]
proposed patch
Comment 2 Gustavo Noronha (kov) 2010-08-11 22:47:06 UTC
Created attachment 167677 [details] [review]
proposed patch

Actually, we need to ref the decision, and there's a leak in webkitgtk.
Comment 3 Xan Lopez 2010-08-22 07:52:18 UTC
Comment on attachment 167677 [details] [review]
proposed patch

The style for the { in the if is wrong, r=me otherwise
Comment 4 Gustavo Noronha (kov) 2010-08-24 19:36:29 UTC
Comment on attachment 167677 [details] [review]
proposed patch

Pushed as 0895fc6f23ec5a589a2b34f720e4fcf208a078df and a brown paper bag commit fixing the style issue as cb80122bfecf6b7e6d088637e8445f543f85c50a ;D