After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554767 - IRC tab completion only works with letters
IRC tab completion only works with letters
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
2.29.x
Other All
: Normal minor
: ---
Assigned To: empathy-maint
: 565589 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-02 20:43 UTC by Bruce Cowan
Modified: 2010-01-06 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix autocompletion for non-alphanumeric nicknames (1.05 KB, patch)
2010-01-02 16:17 UTC, Thomas Meire 		none Details | Review

Description Bruce Cowan 2008-10-02 20:43:19 UTC 
Please describe the problem:
Only letters work with tab completion. If a name has numbers in it, it can't be completed.

Steps to reproduce:
1. Try tab completion with a contact with a number in their name


Actual results:
It doesn't work

Expected results:
It should work (surprising)

Does this happen every time?


Other information:
Out of interest, how do you switch off "easy" bug filing mode?
Comment 1 Bruce Cowan 2008-10-02 20:46:58 UTC 
Actually, it may not work with only letters, but some names are impossible to get to work.
Comment 2 Frederic Peters 2008-12-26 12:38:47 UTC 
*** Bug 565589 has been marked as a duplicate of this bug. ***
Comment 3 Sumana Harihareswara 2009-12-15 22:13:00 UTC 
Test cases: the nicknames 

[ae86]
_bt
|S3GA|
Comment 4 Thomas Meire 2010-01-02 16:17:38 UTC 
Created attachment 150687 [details] [review]
Fix autocompletion for non-alphanumeric nicknames

This bug is caused by the behaviour of gtk_text_iter_backward_word_start. It searches the text for delimiters, based on languages in pango. Numbers and characters as | and [ are not considered to be part of a word in most languages, while they are a part of nicknames. Therefore, empathy fails to get the typed part of the nickname.
The attached patch will instead search backwards for a space character. The text that needs to be completed, is the text between the caret and the fist space before that.
Comment 5 Guillaume Desmottes 2010-01-06 11:04:21 UTC 
Thanks a lot for your patch. I fixed coding style and pushed it to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.