After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 534056 - gnome-2-22 branch does not compile
gnome-2-22 branch does not compile
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: [obsolete] Backend:Mozilla
2.22.x
Other Linux
: Normal blocker
: gnome-2-22
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-20 14:28 UTC by Wouter Bolsterlee (uws)
Modified: 2008-05-24 04:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22



Description Wouter Bolsterlee (uws) 2008-05-20 14:28:05 UTC
g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib -I../../embed -I../.. -I/usr/include/xulrunner/. -I/usr/include/xulrunner/caps -I/usr/include/xulrunner/chardet -I/usr/include/xulrunner/chrome -I/usr/include/xulrunner/commandhandler -I/usr/include/xulrunner/content -I/usr/include/xulrunner/cookie -I/usr/include/xulrunner/docshell -I/usr/include/xulrunner/dom -I/usr/include/xulrunner/exthandler -I/usr/include/xulrunner/fastfind -I/usr/include/xulrunner/helperAppDlg -I/usr/include/xulrunner/find -I/usr/include/xulrunner/gfx -I/usr/include/xulrunner/gtkembedmoz -I/usr/include/xulrunner/history -I/usr/include/xulrunner/js -I/usr/include/xulrunner/layout -I/usr/include/xulrunner/locale -I/usr/include/xulrunner/mimetype -I/usr/include/xulrunner/necko -I/usr/include/xulrunner/nkcache -I/usr/include/xulrunner/passwordmgr -I/usr/include/xulrunner/pipboot -I/usr/include/xulrunner/pipnss -I/usr/include/xulrunner/pref -I/usr/include/xulrunner/shistory -I/usr/include/xulrunner/string -I/usr/include/xulrunner/sidebar -I/usr/include/xulrunner/spellchecker -I/usr/include/xulrunner/uriloader -I/usr/include/xulrunner/uconv -I/usr/include/xulrunner/wallet -I/usr/include/xulrunner/webbrowserpersist -I/usr/include/xulrunner/webbrwsr -I/usr/include/xulrunner/widget -I/usr/include/xulrunner/windowwatcher -I/usr/include/xulrunner/xmlextras -I/usr/include/xulrunner/xpcom -I/usr/include/xulrunner/xpconnect -DSHARE_DIR=\"/opt/gnome-2-22/share/epiphany\" -DPLUGINDIR=\"/opt/gnome-2-22/lib/epiphany/2.22/plugins\" -DMOZILLA_HOME=\"/usr/lib/xulrunner\" -DMOZILLA_PREFIX=\"/usr\" -DMOZILLA_NATIVE_PLUGINSDIR=\"/opt/gnome-2-22/lib/mozilla/plugins\" -DUA_VERSION=\"2.22\" -DALLOW_PRIVATE_API -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGCONF_DISABLE_DEPRECATED -DLIBGLADE_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DXP_UNIX -DJS_THREADSAFE -I/usr/include/xulrunner -I/usr/include/xulrunner/xpcom -I/usr/include/xulrunner/string -I/usr/include/nspr -I/usr/include/mozjs -I/usr/include/xulrunner/gtkembedmoz -I/usr/include/nspr -DORBIT2=1 -pthread -I/opt/gnome-2-22/include/glib-2.0 -I/opt/gnome-2-22/lib/glib-2.0/include -I/opt/gnome-2-22/include/gio-unix-2.0/ -I/opt/gnome-2-22/include/gtk-2.0 -I/opt/gnome-2-22/lib/gtk-2.0/include -I/opt/gnome-2-22/include/atk-1.0 -I/opt/gnome-2-22/include/cairo -I/opt/gnome-2-22/include/pango-1.0 -I/opt/gnome-2-22/include -I/opt/gnome-2-22/include/pixman-1 -I/opt/gnome-2-22/include/gtk-unix-print-2.0 -I/opt/gnome-2-22/include/libgnome-2.0 -I/opt/gnome-2-22/include/orbit-2.0 -I/opt/gnome-2-22/include/gconf/2 -I/opt/gnome-2-22/include/gnome-vfs-2.0 -I/opt/gnome-2-22/lib/gnome-vfs-2.0/include -I/opt/gnome-2-22/include/libbonobo-2.0 -I/opt/gnome-2-22/include/bonobo-activation-2.0 -I/opt/gnome-2-22/include/libgnomeui-2.0 -I/opt/gnome-2-22/include/libart-2.0 -I/opt/gnome-2-22/include/gnome-keyring-1 -I/opt/gnome-2-22/include/libbonoboui-2.0 -I/opt/gnome-2-22/include/libgnomecanvas-2.0 -I/opt/gnome-2-22/include/gail-1.0 -I/opt/gnome-2-22/include/libglade-2.0 -I/opt/gnome-2-22/include/gnome-desktop-2.0 -I/opt/gnome-2-22/include/startup-notification-1.0 -I/opt/gnome-2-22/include/dbus-1.0 -I/opt/gnome-2-22/lib/dbus-1.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libxml2 -fno-rtti -fshort-wchar -g -O2 -Wall -Wno-unused -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -g -O2 -MT libephymozillaembed_la-mozilla-embed-single.lo -MD -MP -MF .deps/libephymozillaembed_la-mozilla-embed-single.Tpo -c mozilla-embed-single.cpp  -fPIC -DPIC -o .libs/libephymozillaembed_la-mozilla-embed-single.o
mozilla-embed-single.cpp: In function ‘gboolean impl_init(EphyEmbedSingle*)’:
mozilla-embed-single.cpp:590: warning: unused variable ‘rv’
mozilla-embed-single.cpp: In function ‘void impl_remove_password(EphyPasswordManager*, EphyPasswordInfo*)’:
mozilla-embed-single.cpp:1177: error: no matching function for call to ‘nsDerivedSafe<nsIPasswordManager>::RemoveUser(nsString_external&, nsString_external&)’
/usr/include/xulrunner/necko/nsIPasswordManager.h:59: note: candidates are: virtual nsresult nsIPasswordManager::RemoveUser(const nsACString&, const nsAString&)
mozilla-embed-single.cpp:1076: warning: unused variable ‘rv’
make[4]: *** [libephymozillaembed_la-mozilla-embed-single.lo] Error 1
make[4]: Leaving directory `/opt/gnome-2-22/src/epiphany/embed/mozilla'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/opt/gnome-2-22/src/epiphany/embed'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/opt/gnome-2-22/src/epiphany/embed'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/gnome-2-22/src/epiphany'
make: *** [all] Error 2
Comment 1 Claudio Saavedra 2008-05-21 01:21:10 UTC
This seems to happen with gecko 1.8. Haven't tested with gecko 1.9, though.
Comment 2 Christian Persch 2008-05-23 21:03:26 UTC
Should be fixed in svn trunk, please confirm and resolve.
Comment 3 Claudio Saavedra 2008-05-23 21:23:00 UTC
Still doesn't build:

mozilla-embed-single.cpp: In function ‘gboolean impl_init(EphyEmbedSingle*)’:
mozilla-embed-single.cpp:590: warning: unused variable ‘rv’
mozilla-embed-single.cpp: In function ‘void impl_remove_password(EphyPasswordManager*, EphyPasswordInfo*)’:
mozilla-embed-single.cpp:1160: error: no matching function for call to ‘nsDerivedSafe<nsIPasswordManager>::RemoveUser(nsCString_external&, nsCString_external&)’
/usr/include/xulrunner/necko/nsIPasswordManager.h:59: note: candidates are: virtual nsresult nsIPasswordManager::RemoveUser(const nsACString&, const nsAString&)
make[4]: *** [libephymozillaembed_la-mozilla-embed-single.lo] Error 1
Comment 4 Claudio Saavedra 2008-05-24 04:04:30 UTC
I had stupidly resolved this before it got actually fixed. Sorry about that.

The build is now actually fixed. There's only a unused variable warning left:

  mozilla-embed-single.cpp:590: warning: unused variable ‘rv’

This could be easily fixed:

Index: embed/mozilla/mozilla-embed-single.cpp
===================================================================
--- embed/mozilla/mozilla-embed-single.cpp	(revisión: 8248)
+++ embed/mozilla/mozilla-embed-single.cpp	(copia de trabajo)
@@ -587,8 +587,8 @@ impl_init (EphyEmbedSingle *esingle)
 	NS_LogInit ();
 #endif
 
-	nsresult rv;
 #ifdef XPCOM_GLUE
+	nsresult rv;
 	static const GREVersionRange greVersion = {
 	  "1.9a", PR_TRUE,
 	  "2", PR_TRUE