GNOME Bugzilla – Bug 99860
"Add / Modify comment..." is a badly chosen name
Last modified: 2004-12-22 21:47:04 UTC
The name of the "Add / Modify comment..." menu item in the Insert menu and the sheet's popup menu is not so good. The tool tip even starts with "Edit ...". That's a lot of verbs (insert, add, modify and edit) for just one menu item. A better approach is probably to simplify "Add / Modify comment..." to "Comment..." in both the Insert menu and the sheet's popup menu. I'll post a patch that changes this in both the non-bonobo version and the bonobo version. As a side note, I even think that the "Comment..." menu item should belong to the Edit menu. Though, the Edit menu will be very crowded until there is a separate Search top-level menu (see also bug 99655). Anyway, this issue should be filed separately.
Created attachment 12626 [details] [review] unified context diff
WHile I can see the point made here, the suggested solution hides the fact that this menu item is also used to edit an existing comment. Insert->Comment sounds like adding a comment. Perhaps we need a matching item in the Edit menu?
I was rather thinking of moving (as opposed to duplicating) the "Comment..." menu item towards the Edit menu. The tool tip also suggests this ("Edit the selected cell's comment"). Insert menu operations such as "Graph...", "Image..." and "Function..." really insert data or an object. The "Comment..." menu item merely edits an attribute of a cell. Therefore I think that the "Comment..." menu item has nothing to do in the Insert menu.
Created attachment 13246 [details] [review] unified context diff
The above patch changes the text of the "Add / Modify comment..." menu items to "Comment...". Additionally, the "Comment..." menu item in the "Insert" menu is moved to the "Edit" menu.
Fixed in cvs
Edit is already somewhat overful. XL has Insert -> comment and modifies that to be Edit Comment when there is a comment in the edit position. Which fits nicely with creation, but not nicely with modification. I don't see the comment as an attribute of the cell. It is a full blown object, right down to the implementation. If it were an attribute of the cell we'd have ended up putting it in the cell format dialog along with all the other things we've lumped in there that are not in XL. i'd like to reopen this and get some usability feed back
I have filed Bug 116535 which supercedes and would solve this problem. SO I mark this one as a duplicate of 116535. *** This bug has been marked as a duplicate of 116535 ***