After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 99535 - [ui-review] Theme manager UI issues
[ui-review] Theme manager UI issues
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] theme-manager
2.13.x
Other other
: Normal minor
: ---
Assigned To: Thomas Wood
Control-Center Maintainers
Depends on:
Blocks: 115435
 
 
Reported: 2002-11-25 18:28 UTC by Andrew Sobala
Modified: 2006-04-19 18:29 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14

Attachments
Removes the drag and drop install instruction text (35.72 KB, patch)
2006-01-07 18:41 UTC, Thomas Wood 		none Details | Review
Remove the text and add Install button to each tab (47.99 KB, patch)
2006-04-18 22:22 UTC, Thomas Wood 		committed Details | Review

Description Andrew Sobala 2002-11-25 18:28:51 UTC 
- Go to theme folder seems silly
-- only reason is to delete themes? in which case there should be a Remove
Theme button
-- in any case, remove the ellipsis
-- s/Go to theme folder/Go to Theme Folder

- Remove help text for dragging tarballs onto the dialog
-- if not, read "You can also drag a theme into this window to install the
theme"
Comment 1 Andrew Sobala 2002-11-25 18:32:50 UTC 
The UI review team noted that this dialog is rapidly changing and
noted that it may be worth revisiting it at a later stage.
Comment 2 Christian Kirbach 2005-05-14 23:20:52 UTC 
I think this is obsolete now.
Reopen if you think it is not.
Comment 3 Andrew Sobala 2005-05-14 23:54:55 UTC 
Nope. (It's under the "Theme details" button.)
Comment 4 Thomas Wood 2005-12-30 15:54:56 UTC 
Which part of this bug is still valid? Just that the "Go to Theme Folder" button still exists and the help text?
Comment 5 Thomas Wood 2006-01-07 18:41:34 UTC 
Created attachment 56927 [details] [review]
Removes the drag and drop install instruction text

The Goto Theme Folder button has already been removed. This patch removes the drag and drop to install theme text from the theme details dialog.
Comment 6 Sebastien Bacher 2006-01-08 13:02:37 UTC 
Any reason to remove the note about beeing able to install theme by dnd? Usability team, do you have an opinion on that? Why does the ui-review recommended to drop it?
Comment 7 Calum Benson 2006-01-18 18:30:35 UTC 
When the Sun guys wrote a lot of the user docs (and the style guide), they were very much against placing 'help text' like this in windows and dialogs, believing that help belonged in the documentation.  While such text always has some potential to mess up dialog layouts in other locales, the Sun docs guys aren't working on GNOME any more, and the HIG is silent on the issue, so I guess it's up to the maintainer...
Comment 8 Thomas Wood 2006-04-12 20:17:37 UTC 
Maybe if the individual tabs had an "Add" button, then the text would be redundant? As it is, it's only useful once anyway. I would agree that this sort of information should really only be in the documentation.
Comment 9 Thomas Wood 2006-04-18 22:22:25 UTC 
Created attachment 63835 [details] [review]
Remove the text and add Install button to each tab

As per comment #7. OK to commit?
Comment 10 Thomas Wood 2006-04-19 10:52:38 UTC 
Sebastien gave the thumbs up on the patch, with _swapped removed from signal connect calls.
Comment 11 Andrew Sobala 2006-04-19 18:29:34 UTC 
You can't close this bug, it had vintage taste ;-)