GNOME Bugzilla – Bug 99439
items count is misleading for inaccessible directories
Last modified: 2017-08-17 13:59:22 UTC
When "show number of items in folders" is turned on, but the directory is not readable, "? items" is displayed. This is ugly. Better would be to simply display no text in this case, or "number of items unknown" if totally neccesary.
This is still true for 2.1.2.
Is this still relevant?
With CVS head, this is not relevant anymore and the bug could be closed.
Er no, this is still here in Nautilus 2.6.3. Just find a directory on your filesystem which you dont have permission to read, "? items" is still displayed.
Yup, this is still an issue for Nautilus 2.12. I think "? items" was chosen because it is extremely terse. "number of items unknown" seems to be a bit too long. We should really choose a better label, which still fits into one line. Any suggestions? Milestoning to future, since it breaks string freeze.
Why not simply show nothing? If there's nothing to say, don't say it.
Mass changing Nautilus version for bugs that have GNOME 2.13 version info.
What's up with this issue ? The SVN HEAD still display "? items". What behavior has been decided for this ?
It still exists as of GNOME nautilus 3.15.90.
Still valid. Currently (Nautilus 3.5.90), nautilus displays: (1)- an ellipsis (...) while reading the number of items (2)- two dashes (--) if folder item count is disabled (by default for remote locations) (3)- and "? items" for folders I have no permission to read (/root for instance) However, without this knowledge, the meaning expressed by "--" and "? items" is the same: the number of items not shown. While there is a different underlying cause (disabled vs. unreadable), is there any reason to use two different strings that don't convey these causes? "? items" could be replaced by "unkown" but while that's a short word, it can be long in other locales ("desconhecido" in Portuguese, for instance).
Created attachment 357492 [details] [review] file: Change string of unreadable directory item count For the reasons stated in the previous comment, I propose to replacing "? items" with "--". If the user wants more details, those are already available in the Properties dialog, which will either calculate the icon count (for remote folders) or state that contents are unreadable.
Created attachment 357494 [details] [review] file: Change string of unreadable directory item count Previous patch was messy, sorry.
Review of attachment 357494 [details] [review]: Thanks for the patch! Some changes: ::: src/nautilus-file.c @@ +7542,3 @@ nautilus_file_get_directory_item_count (file, &item_count, &count_unreadable); } + return g_strdup (count_unreadable ? "--" : "..."); Change it for their utf counterparts, both the three dots and the dash.
Great idea! We probably should do it for the other occurrences of "..." in the surrounding code. May be worth a separate patch? There are also 2 strings nearby "? bytes" and "? items", but I have no idea where in the UI they are shown.
Created attachment 357545 [details] [review] file: Use Unicode ellipsis and em dash for default attribute strings This is supposed to apply on top of the previous patch. It converts more instances of "..." than the one from the previous patch. Carlos, should I merge the two patches or is it better to keep the changes separated like this?
Review of attachment 357545 [details] [review]: LGTM!
Review of attachment 357494 [details] [review]: Looks good now.
(In reply to António Fernandes from comment #15) > Created attachment 357545 [details] [review] [review] > file: Use Unicode ellipsis and em dash for default attribute strings > > This is supposed to apply on top of the previous patch. It converts more > instances of "..." than the one from the previous patch. > > Carlos, should I merge the two patches or is it better to keep the changes > separated like this? Separated is fine, thanks!
Great! We may close a 15 years old bug. :) Feel free to push for me if this doesn't break any freeze.
Almost 15 years, anyway. Thanks folks, I'm really excited to see my bug finally being fixed. It beats my previous record of 5 years for bug 304336.
Attachment 357494 [details] pushed as 0fe9cc2 - file: Change string of unreadable directory item count Attachment 357545 [details] pushed as 33694f0 - file: Use Unicode ellipsis and em dash for default attribute strings