After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98315 - error when an application (xine) changes to fullscreen mode
error when an application (xine) changes to fullscreen mode
Status: RESOLVED FIXED
Product: Sawfish
Classification: Deprecated
Component: Window Manager
pre-1.3.x
Other Linux
: Normal normal
: 1.5.x
Assigned To: John Harper
sawfish QA Team
Depends on:
Blocks:
 
 
Reported: 2002-11-12 15:53 UTC by Christian Marillat
Modified: 2009-08-16 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Marillat 2002-11-12 15:53:30 UTC
Hi,

http://bugs.debian.org/168795

I use xine to view DVDs, and often use it in its fullscreen mode.
This used to work fine, but now I get a beep every time.  The error in
.xsession-errors is this:

Bad argument: #<subr get-x-property>, 0, 1
Bad argument: #<closure adjust-position-for-gravity/y>, (0 . 0), 2
Comment 1 Vesa Halttunen 2002-11-13 00:19:03 UTC
This also happens with other applications like MPlayer and MoTV. I
didn't see this with Sawfish 1.1 but I do see this with Sawfish 1.2.
Comment 2 Christian Marillat 2002-11-13 09:59:23 UTC
Not with mplayer.
Comment 3 John Harper 2002-11-13 19:27:47 UTC
this patch fixes things for xine, at least:

--- sawfish/wm/windows.jl       4 Nov 2002 03:35:38 -0000       1.30
+++ sawfish/wm/windows.jl       13 Nov 2002 19:23:08 -0000
@@ -320,7 +320,7 @@ If HINTS is non-nil, then it is the size
            (t x))))
 
   (define (adjust-position-for-gravity/y w grav y #!key inverse)
-    (let* ((tl-off (window-frame-offset w))
+    (let* ((tl-off (cdr (window-frame-offset w)))
           (br-off (- (cdr (window-frame-dimensions w))
                      (cdr (window-dimensions w))))
           (sign (if inverse -1 +1)))
Comment 4 Christian Marillat 2002-11-13 20:03:26 UTC
I can reproduce this bug with xawtv with your patche applied; But
maybe this is another bug.

Lisp backtrace:
#1   adjust-position-for-gravity/y ...
  • #0 configure-request-handler

Bad argument: #<closure adjust-position-for-gravity/y>, (-6 . -19), 2
Comment 5 Thomas de Grenier de Latour 2002-11-13 21:09:12 UTC
I had the same bug bug with "xawdecode", a xawtv like application.
John's patch has solved it.

Thanks.
Comment 6 John Harper 2002-11-14 07:04:23 UTC
should be fixed now
Comment 7 Christian Marillat 2002-11-14 11:11:38 UTC
With your patch ? I've received a feedback from the user who reported
this bug for xine, and this doesn't work.
Comment 8 Christian Marillat 2002-11-14 13:59:06 UTC
OK, this bug is fixed.
Comment 9 Joe Kelsey 2003-02-14 16:31:27 UTC
You fixed the window gravity problem, but you completely ignored the
#<subr get-x-property> bug, which still occurs.

Whenever I open gmplayer, sawfish reports

Bad argument $<subr get-x-property> 0,1

This comes from the C code, indicating that the window argument passed
to get-x-property is invalid.
Comment 10 John Harper 2003-02-15 21:18:16 UTC
see above
Comment 11 Joe Kelsey 2003-02-15 22:39:43 UTC
The #<subr get-x-property> bug still exists.  The windows.jl fix does
not fix the get-x-property bug.
Comment 12 Joe Kelsey 2003-02-15 23:38:35 UTC
Just in case you are wondering, here are several scenarios to tickle
the bug.

Start gmplayer.  Sit back and watch the sawfish errors.

Start mplayer.  During play, bring up the preferences dialog.  Sit
back and watch the sawfish errors.

I have installed the windows.jl fix.
Comment 13 John Harper 2003-02-16 00:30:58 UTC
ok, my mistake

put (setq backtrace-on-error '(bad-arg)) in your .sawfishrc and paste
the backtrace in here
Comment 14 Joe Kelsey 2003-02-18 03:54:15 UTC
Lisp backtrace:
#3   get-x-property ...
#2   sm-get-window-prop ...
#1   match-window-to-alist ...
  • #0 match-window
 
*** Bad argument: #<subr get-x-property>, 0, 1
Comment 15 John Harper 2003-08-15 08:10:00 UTC
I checked in something that may fix this, if not run sawfish in
--interp mode and recapture the backtrace, thanks