After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 98120 - 1.1.2 fails to build outside of build directory
1.1.2 fails to build outside of build directory
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: build
unspecified
Other other
: Low normal
: ---
Assigned To: bill.haneman
bill.haneman
Depends on:
Blocks:
 
 
Reported: 2002-11-09 20:10 UTC by Mike Castle
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (780 bytes, patch)
2003-01-15 14:32 UTC, padraig.obriain 		none Details | Review
Proposed patch (780 bytes, patch)
2003-01-15 14:35 UTC, padraig.obriain 		none Details | Review

Description Mike Castle 2002-11-09 20:10:16 UTC 
I try to build all autoconfed packages outside of their build directory.

In order to build outside of $srcdir, I have to apply the following patch 
to Makefile.in:

patch -p1 << \EOF
diff -ru at-spi-1.1.2.orig/libspi/Makefile.in at-spi-
1.1.2/libspi/Makefile.in
--- at-spi-1.1.2.orig/libspi/Makefile.in        2002-10-15 
05:32:29.000000000 -0700
+++ at-spi-1.1.2/libspi/Makefile.in     2002-11-09 11:42:30.000000000 -0800
@@ -516,9 +516,6 @@
 distclean-generic clean-generic maintainer-clean-generic clean \
 mostlyclean distclean maintainer-clean
 
-
-accessible.c base.h keystrokelistener.h libspi.h listener.h 
remoteobject.h : Accessibility.h
-
 $(IDL_OUT) Accessibility-imodule.c : $(IDL_DEPS) $(ORBIT_IDL)
        $(ORBIT_IDL) -D__ACCESSIBILITY_COMPILATION__ $(IDLFLAGS) 
$(top_srcdir)/idl/Accessibility.idl
 
EOF

This line comes directly from Makefile.am and was introduced in revision 
1.30/1.31.  I'm not sure what automake problem it was trying to fix, but 
that doesn't seem to be the best solution.
Comment 1 padraig.obriain 2003-01-15 14:32:59 UTC 
Created attachment 13586 [details] [review]
Proposed patch
Comment 2 padraig.obriain 2003-01-15 14:35:19 UTC 
Created attachment 13587 [details] [review]
Proposed patch
Comment 3 bill.haneman 2003-01-15 14:57:47 UTC 
Looks good Padraig.  Can we commit or should we run it past
release-team first?

If there are a number of 'obvious fixes' like this we could probably
group them into one email.
Comment 4 padraig.obriain 2003-01-15 15:06:52 UTC 
Patch committed to CVS HEAD.