GNOME Bugzilla – Bug 96000
Toolbar ignores GtkToolbar::shadow_type gtkrc setting
Last modified: 2004-12-22 21:47:04 UTC
Description of Problem: (This is not just a gedit bug, but I don't know whose bug this is: please reassign to the correct component.) gedit (and other GNOME 2.0 applications, including file-roller and nautilus) ignore the GtkToolbar::shadow_type setting. The only application I can find which honours the setting is yelp. Steps to reproduce the problem: 1. Add the following line to your ~/.gtkrc-2.0: style "default" { GtkToolbar::shadow_type = GTK_SHADOW_NONE } 2. Load gedit 3. Load yelp Actual Results: The gedit toolbar looks raised, the yelp toolbar looks flat. Expected Results: Both toolbars look flat (yay flat toolbars). How often does this happen? Every time. Additional Information: I'm using the ThinIce theme engine.
-> gtk Can't verify right now, my GNOME machine is off. Not sure which module this is, since it's selective weirdness: Owen, any ideas?
I forgot to mention: of the three program sources I checked, yelp was the only one to directly use a GtkToolbar object. I don't know how the other two worked, but they both used bonobo_activation in vague relation to their toolbar display.
Most gnome apps are using a toolbar widget in bonoboui rather than GtkToolbar. The shadow-type setting works fine in testgtk, so I think your problem is with the Bonobo widget.
Since the Bonobo UI toolbar doesn't render a shadow at all; this is probably down to the DockItem or somesuch; While there is a 'shadow' property on the DockItem - there is no widget_class_style property - we should perhaps add one - see libbonoboui/bonobo/bonobo-dock-item.[ch] - hack there. Is this useful Tiger ?
This is fixed in HEAD by virtue of my addition of the shadow_type style property to BonoboUIToolbar. If you are using libbonoboui HEAD, you can set the BonoboUIToolbar::shadow-type style property to match the gtk+ style property for the toolbar. Since BonoboUIToolbar is not a child of GtkToolbar, this was how it had to be implemented. I am waiting for some kind of comment from owen with bug 106336 to see what to do about the default drawing of GtkToolbar. I will then change BonoboUIToolbar to match it exactly. Either the first patch in that bug, or the modified patch with shadow_type set to NONE by default seems best. Should this be resolved as a dup of bug 106361?
I'm leaving this entirely to you Dobey; go for it :-)
Ok. Doing what dobey got permission to do :-) *** This bug has been marked as a duplicate of 106361 ***