GNOME Bugzilla – Bug 95362
can't drop rows on empty treeviews | treestore reordering broken
Last modified: 2011-02-04 16:16:03 UTC
I am trying to enable drag and drop between 2 GtkTreeViews with the next functions: -gtk_tree_view_enable_model_drag_source -gtk_tree_view_enable_model_drag_dest obtained result: When I drag a cell from one tree to another, I can drop only where there are cells, and thus, If the dest tree is empty, I cannot drop anything. expected result: It should allow dropping in all the GtkTreeView area, not only in the area filled by cells
Moving remaining bugs to 2.2.1.
I think I need a new entry in GtkTreeViewDropPosition in order to fix this cleanly. Moving to 2.4 API freeze.
Euhm, not sure what I was smoking last time, I don't need a new entry in GktTreeViewDropPosition. It's doable within the current situation, provided using enough hacks/special cases. I have a prototype patch, which works. Though I need to rewrite it first before I even dare to attach it here. Moving back to 2.2.x.
Created attachment 16930 [details] [review] primarily patch, might need some work later on.
Created attachment 17777 [details] [review] updated patch removing -drop-append object data usage as per #113314
I applied this patch (id=17777) to debian gtk+ 2.2.1-6 looking for a possible solution to galeon bug #93234, but the behavior is now that I cannot drop a TreeView (bookmark editor) row into *any* folder rather than just an empty one. Before, the row would simply not drop at all if the destination folder was empty. Now, it will drop immediately above the folder in the same level, empty or not.
Is there some screenshot of this bookmark dialog and folder dialogs? I really need some more context here to understand what you are exactly saying. I tested my fix with testtreecolumns and it works fine there.
Sorry, I forgot to clarify, the application I was talking about is the bookmark editor in Galeon 1.3.5 which uses TreeView. In the screenshot: Without the patch, I can drop the Google bookmark into Folder 1, but not Folder 2 With the patch, I cannot drop it into either.
Created attachment 18017 [details] galeon screenshot
Oh, right. Then you are a dup of 113619 and not this bug ;).
That may be the case, but if this fix is applied to 2.2.x and 113619 is 2.4, things that need to be able to do that will be MORE broken until 113619 is fixed (the duration of 2.2.2+)
*** Bug 113619 has been marked as a duplicate of this bug. ***
Will attach an updated patch which also fixes treestore reordering as per bug #113619. The updated patch uses doesn't use object data anymore, but just adds flags to GtkTreePrivate which results in cleaner code.
Created attachment 18244 [details] [review] updated patch
This patch seems to work pretty well. It seemed a little hard on the CPU, though that could have been other circumstances. No complaints here.
http://mail.gnome.org/archives/gtk-devel-list/2003-August/msg00101.html Moving to 2.4.
Created attachment 19279 [details] [review] updated patch (Aug 16)
Created attachment 19835 [details] [review] patch as committed
Finally committed on HEAD. yay.
great! I suppose that HEAD will be 2.4, can't wait to port my current programs to 2.4 and test it :-) great work, kris!