After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 95150 - Serious bug in xim-immodule
Serious bug in xim-immodule
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Input Methods
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2002-10-08 08:34 UTC by Takuro Ashie
Modified: 2011-02-04 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for xim-immodule (479 bytes, patch)
2002-10-08 08:37 UTC, Takuro Ashie 		none Details | Review

Description Takuro Ashie 2002-10-08 08:34:51 UTC 
Gtk+-2.0 has serious bug in modules/input/gtkimcontextxim.c.
Here is the patch for this bug:



diff -Nur gtk+-2.0.6-bak/modules/input/gtkimcontextxim.c
gtk+-2.0.6/modules/inpu
t/gtkimcontextxim.c
--- gtk+-2.0.6-bak/modules/input/gtkimcontextxim.c      Thu Jul 11 03:26:33
2002
+++ gtk+-2.0.6/modules/input/gtkimcontextxim.c  Tue Oct  8 00:07:10 2002
@@ -216,7 +216,7 @@
       if (im)
        {
          info = g_new (GtkXIMInfo, 1);
-         open_ims = g_slist_prepend (open_ims, im);
+         open_ims = g_slist_prepend (open_ims, info);
          
          info->locale = g_strdup (locale);
          info->im = im;



This bug causes memory leak and XOpenIM will be called every
time because locale string is never matched with existing xim
instances.

So application works with Gtk+-2.0 seems unstable on Japanese
environment.
Comment 1 Takuro Ashie 2002-10-08 08:37:07 UTC 
Created attachment 11444 [details] [review]
patch for xim-immodule
Comment 2 Owen Taylor 2002-10-08 13:51:15 UTC 
Fix applied, thanks.

Tue Oct  8 09:41:43 2002  Owen Taylor  <otaylor@redhat.com>

        * Patch from Takuro Ashie to fix updating of open_ims
        list. (#95150)