GNOME Bugzilla – Bug 95115
'Select Custom Icon' in file properties dialog should be more like that of 'Icon: ' in launcher properties
Last modified: 2005-12-16 19:28:30 UTC
first thing not in the ui review, but this window should be a dialog not have a maximize button only minimize and close: see: http://developer.gnome.org/projects/gup/hig/1.0/windows.html#property-windows even though i should add that most such windows in gnome only have a close button and no minimize. ok on to ui review stuff... 1. Icon preview should be moved down closer to the 'Select Custom Icon...' and 'Remove Custom Icon' buttons. I think a better way to do this would be to copy the launcher properties dialog (ie. select custom icon button has a preview of the currently being used image and users can click on the button to use the icon chooser to select a custom icon) 2. The Emblems tab scrollbar scrolls too much for the number of emblems present. known bug. 3. All dialog element labels appear in 'bold', inconsistant with the rest of GNOME? I'm not sure i agree with this. 4. Dialog doesn't resize well, but you shouldn't be able to resize it all right?
The only one of these complaints that still appears to be valid is #1, so, re-titleing this bug appropriately.
Removing keywords and upping version.
Created attachment 37667 [details] [review] Proposed patch This patch adds an icon button chooser and makes the dialog non-resizable. Making it non-resizable also prevents the maximize window manager button from appearing. I did not address the issue of bold labels, since there seems to be some disagreement. This patch puts the icon button near the bottom of the page, because that's closest to the old icon buttons.
the patch looks really weird with some locales, depending of the label for the properties windows. It's confusing for the Emblems tabs which can look weird too. I'm marking the patch as need-work
Created attachment 46385 [details] example for the emblems
Created attachment 46386 [details] tab with the patch
I don't see what's wrong with the emblem tag there. You mean how there is a lot of space on the right of the scroll widget? That is weird, but that's not my patch, I think. I see that here on my stock 2.10 nautilus. The emblem widget sizing weirdly is a separate bug. Also, I don't think the General tab looks weird, but that's more of a toss-up. The large width is at least directly attributable to the patch. But doesn't it look just as wide without the patch? Do you have an idea for how to fix the General tab and/or the Emblem tab?
Sebastien: I've just launched gnome-about-me and I found its way of selecting a custom icon *very* cool and unintrusive: Just a button with a pixbuf which brings up a file chooser with a "No Icon" button. Couldn't we add something like this for the custom icon chooser as well, and get rid of the property dialog revert button. We could label it "Reset Icon" or "Default" and grey it out if the default icon is selected.
I was reading through the comments here and was actually going to propose exactly what Christian proposes in comment 8 ... :-) I'd like to protest against moving the icon to the bottom, though. The two identifiers we have for a launcher is its name and its icon. Pairing the two seems logical; separating them seems silly. As for the Emblem tab, it has always been disordered, but I think that should be the focus of a different bug.
Created attachment 51411 [details] [review] Proposed prelimitary patch A quick hack to use the icon chooser and a single button. This breaks UI freeze. Also, it doesn't yet support image preview.
Reassigning to 2.13.
Commited.
Comment on attachment 51411 [details] [review] Proposed prelimitary patch >Index: src/file-manager/fm-properties-window.c >+select_image_button_callback (GtkWidget *widget, >+ dialog = gtk_file_chooser_dialog_new (_("Select Custom Icon"), GTK_WINDOW (window), >+ GTK_FILE_CHOOSER_ACTION_OPEN, >+ _("_Revert"), GTK_RESPONSE_NO, Would it have made sense to use GTK_STOCK_REVERT_TO_SAVED[1] here instead of _("_Revert")? 1: <http://www.gtk.org/api/2.6/gtk/gtk-Stock-Items.html#id2748924>
Yes, good idea. Feel free to come up with a little patch if you want :).
Created attachment 55136 [details] [review] Use GTK_STOCK_REVERT_TO_SAVED Like so? I can't compile it to test now, because the gnome-common package is currently uninstallable in Ubuntu Dapper and ./autogen.sh complains "You need to install gnome-common from the GNOME CVS".
2005-12-16 Martin Wehner <martin.wehner@gmail.com> * src/file-manager/fm-properties-window.c: (select_image_button_callback): Use GTK_STOCK_REVERT_TO_SAVED item for icon selection dialog. Closes #95115. Patch from Vidar Braut Haarr (vhaarr@gmail.com)