Created attachment 11358 [details] [review]
pspell -> aspell API

The patch looks ok to me. Few "but"s:
1. "Could not find a working Aspell library" is not particularly
informative.
2. on my system, instalation of aspell-devel requires pspell-devel anyway.
3. existence of new_aspell_speller is being checked but
aspell-0.33.7.1-16 does not appear to define it. This was a
show-stopper for me.

Actually, I am quite annoyed with pspell, the question is whether
aspell is any better - but I cannot answer it.

let's go through your points:
1. I'll change it to the standard form
2. + 3. Your packages are heavily outdated. Look at http://aspell.net,
Section Quick Links -> Manual -> Chapter 2.5.4. If you are annoyed
with other *spell solutions, look up chapter 1.1.1.

see you,
 Chris

Thanks for the comments. The only problem I see now is that applying
this patch would force all balsa users to upgrade aspell. All users
would be forced, even those who do not use spelling.
I cannot say now whether this would be a big problem, or not.

The patch does not appear to work with 2.0.3

>patch -Np1 -i /home/dexter/balsa-aspell-patch
>patching file configure.in
>patching file src/balsa-app.c
>Hunk #2 succeeded at 405 (offset 4 lines).
>patching file src/balsa-app.h
>Hunk #1 succeeded at 97 (offset 3 lines).
>patching file src/pref-manager.c
>Hunk #1 FAILED at 2196.
>1 out of 1 hunk FAILED -- saving rejects to file >src/pref-manager.c.rej
>patching file src/save-restore.c
>Hunk #1 succeeded at 666 (offset 12 lines).
>patching file src/spell-check.c
>patching file src/spell-check.h

And then configure bails out saying

>checking for scrollkeeper-config... >/opt/gnome2/bin/scrollkeeper-config
>checking for new_pspell_manager in -lpspell... no
>configure: error: *** libpspell(-devel) not found.  Please check
>http://www.balsa.net for information on the required files.

BALSA_2 branch can work now with aspell>=0.50. I mark the report as fixed.

balsa-2.0.6 released.