GNOME Bugzilla – Bug 89591
Add new columns in the songs-view (my rating, play count)
Last modified: 2004-12-22 21:47:04 UTC
Rhythmbox needs 2 new kind of columns: * My ratings - from 1 to 5 stars * Play count - The number of times a song has been played This is, of course, heavily inspired by iTunes: http://perso.wanadoo.fr/oleevye/screenshots/itunes3.png
Created attachment 11792 [details] [review] Initial patch to get 'play count' and 'last played' saved and displayed
The above patch should initialise and record the 'play statistics' of each node. Its not perfect, and doesn't update when the node is the last in the list - but its a start.
Coolness! I see where your bug comes from: you call song_update_statistics at the end of the eos handler, you should do it at the beginning, after GDK_THREADS_ENTER, and instead of calling rb_node_view_previous, you should call rb_node_view_get_playing_node. Further, it would rock if you could add columns for these two guys :) (Yes, we want them here ;) Since in this case they are actually useful)
When I do it inside the GDK_THREADS_ENTER, then the whole thing locks up. I will keep having a play and get columns added for these 2 fields in a later patch.
whoops, TRUE -- do it before the THREADS_ENTER, sorry
Well, the suggested changes work, so I'll move onto forcing in the 2 new columns and resubmit the patch.
Rating is done. You will prolly have some conflict while updating cvs...
Created attachment 11802 [details] [review] Show play count and last played as available columns
Above patch is a re-merge with the CVS checkins from last night. The two fields are available as columns. The formatting is a little 'immature' - no i18n and repeats a couple of functions and could be tidied up. btw. MyRating(tm) looks great.
Created attachment 11803 [details] [review] Correct duplicate short cut keys for 'Last Played' column
Ignore the previous patch, it doesn't change a thing! Will submit a further change later today that fixes a couple of annoying things I have found whilst using the changed version of 'rb'.
Created attachment 11805 [details] [review] Rationalisation of changes and standardisation of duplicated functions
I'm a lot happier with the above patch, duplicated functions rationalised, shortcuts sorted out, dragon slain, etc.
Cleaned it up and commited.