After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 88260 - Pan does not remember window positions correctly
Pan does not remember window positions correctly
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
0.12.0
Other Linux
: Normal minor
: 0.13.1
Assigned To: Charles Kerr
Charles Kerr
Depends on:
Blocks:
 
 
Reported: 2002-07-15 21:01 UTC by Marc Deslauriers
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.0


Attachments
Patch to correct window positioning bug (2.97 KB, patch)
2002-07-15 21:02 UTC, Marc Deslauriers
none Details | Review
Revised patch for window placement (2.99 KB, patch)
2002-07-15 23:38 UTC, Marc Deslauriers
none Details | Review

Description Marc Deslauriers 2002-07-15 21:01:15 UTC
If you open and close Pan a few times, the window position slowly moves
across the screen. It doesn't accurately remember it's position.
Comment 1 Marc Deslauriers 2002-07-15 21:02:36 UTC
Created attachment 9879 [details] [review]
Patch to correct window positioning bug
Comment 2 Marc Deslauriers 2002-07-15 21:03:46 UTC
The patch above also implements functionnality so Pan remembers if its
window is maximized or not.

This is important for the Metacity WM in the next redhat release as it
does not save window positions and states.
Comment 3 Charles Kerr 2002-07-15 22:05:02 UTC
Marc,

This patch needs a little work; gui_save_window_size() is called
not just by the main window but also by the task manager and 
compose window.  But the pan_maximized field looks like it
is set no matter which window calls it.

If I'm reading the code wrong, just whap me with a cluestick
and I'll apply, otherwise please make a revision, perhaps checking
to see if window == Pan.window before using pan_maximized...
Comment 4 Marc Deslauriers 2002-07-15 23:38:56 UTC
Created attachment 9887 [details] [review]
Revised patch for window placement
Comment 5 Marc Deslauriers 2002-07-15 23:39:44 UTC
I'm the one that needs to be whapped with a cluestick :)

Here's a new patch. If anything could be better, please let me
know...I'm new to this.

Marc.
Comment 6 Christophe Lambin 2002-09-12 20:47:51 UTC
Committed. Thanks for the patch.