GNOME Bugzilla – Bug 85285
RLE / uncompressed gif extensions...
Last modified: 2003-07-29 09:44:38 UTC
This adds RLE and uncompressed gif's to the gimp plugin. It has compile time options to possibly removed the code (this might be important from a legal persective for unisys patent countries). This patch does not change the pdb interface which would break some things. the patch is 7k, so I didn't include it here. The changes are simple and available at: http://www.bloke.com/linux/gimp/patches/gif.patch I'll post it here if requested. thanks, Cameron
We should consider this for inclusion in gimp-1.3.
Changes at the request of Dave Neary on the developer mailing list. I am changing many of the bugzilla reports that have not specified a target milestone to Future milestone. Hope that is acceptable.
Any comment on this from Adam? Is it clean enough to go into 1.3 now? If not, would you mind bumping it to Future? Cheers, Dave.
Looks good.
I'll commit this this week. Dave.
Currently the new stuff is hidden behind #defines - should we have a gui option to select a compression? That would imply adding a parameter to the savevals, similar to tiff. Otherwise, we can # enable the new RLE (which made a file twice the size as the LZ encoding when I tried it) and be done with it? Or offer Lempel-Ziff as default, and document the alternatives for people who want to ship a nobbled gif plug-in? I have added the radio group here, so it can be committed more or less at will once this build finishes... Otherwise, I suggest applying this patch, and adding something in the docs (any suggestions where this should be documented, if that's the route we take?) Dave.
>Or offer Lempel-Ziff as default, and document the alternatives for >people who want to ship a nobbled gif plug-in? That one, I think. I also see no merit (certainly not outweighted enormously by clutter) in offering a radio group for this -- it's something that I imagine to be set pretty strictly per-installation, not per-image. Keep the default as-is, and let packagers flip a build-time switch (a doc would be good -- an autoconf option would be magic).
I'd also vote for a configure switch. It's simple to add and would allow distributors who (have to) care about this problem to solve one of the most frequently asked questions, the one about the missing gif plug-in. Packagers could still continue to ship an additional gif-nonfree package that includes a GIF plug-in that uses LZW. How should such a configure switch be called?
I reckon, --with-gif-compression=[lwz/rle/none] (Maybe an explicit 'uncompressed' instead of 'none' to make it clear that you'll still get a gif plugin at all, but its output is uncompressed.)
Created attachment 18693 [details] Screenshot of modified gif save dialog (185K)
Bleh, I meant [lzw/rle/none] of course. To define '(nothing)', 'GIF_RLE', and 'GIF_UN' respectively, for compilation.
Sure, that's aesthetically done Dave, a great layout if we wanted to do that. But really, it's solving a non-problem.
Blegh. Unfortunately I missed this discussion. Here's the final patch to enable the stuff via a radio thing. Will just apply the patch, and add a configure.in bit. Dave.
Created attachment 18699 [details] [review] The never-to-be-applied patch which allowed the user to choose between 3 compression schemes.
Patch applied in CVS, configure flag added. 2003-07-29 Dave Neary <bolsh@gimp.org> * plug-ins/common/gif.c: Include a patch by Cameron Gergory <cameron@bloke.com> which allows a compile-time choice of the comression algorithm to be used in the gif plug-in. * configure.in: Added --with-gif-compress flag to allow specification of compression algorithm via configure.
Thanks anyway Dave. :)
No biggie. I won't hold it against you for long. Dave.