Created attachment 374075 [details] [review]
Meson: Use the 'curl' feature option

Comment on attachment 374075 [details] [review]
Meson: Use the 'curl' feature option

>-curl_dep = dependency('libcurl', version : '>= 7.35.0', required : false)
>+curl_dep = dependency('libcurl', version : '>= 7.35.0', required : get_option('curl'))
> 
> if curl_dep.found()
>   ssh_dep = dependency('libssh2', version : '>= 1.4.3', required : false)

Wonder if we should also use it for the libssh2 check then? Or add a new 'curl-ssh' option for that?

we could have an extra 'ssh2' option, but I don't think we should use get_option('curl') for the libssh2 case, otherwise if we have curl=enabled that would mean that libssh2 is required too, but we should be able to build gstcurl without libssh2.

That can be done in a saparate patch too, I made this one because 'curl' was already in meson_options.txt but not used. (and because it fails to build and I wanted to disable curl as workaround)

Fair enough :)

commit 8dfe0dd9cef9c84b611dc93fdb7785b2746a168f (HEAD -> master)
Author: Xavier Claessens <xavier.claessens@collabora.com>
Date:   Sun Oct 28 06:47:38 2018 -0400

    meson: Use the 'curl' feature option
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797346

commit a4cfb1fa1475cedd296062c6077d21152d36dc04
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Oct 28 11:53:42 2018 +0000

    meson: add 'curl-ssh2' option for curl libssh2 support
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797346