After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797309 - Regression: compile failure in qtdemux (implicit-function-declaration)
Regression: compile failure in qtdemux (implicit-function-declaration)
Status: RESOLVED DUPLICATE of bug 797239
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-19 15:25 UTC by U. Artie Eoff
Modified: 2018-10-20 01:45 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description U. Artie Eoff 2018-10-19 15:25:48 UTC
gst-plugins-good compilation fails on Ubuntu Xenial environment since:

commit b2876ad8a4f7b9f1cdf499ab40c4b73f841c9031
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Sun Oct 7 16:43:34 2018 +0900

    qtdemux: Use GPtrArray to store QtDemuxStream structure
    
    GPtrArray has less overhead than linked list and the length also
    can be auto updated by using it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=797239

Error is:

qtdemux.c: In function 'qtdemux_update_streams':
qtdemux.c:12531:9: error: implicit declaration of function 'g_ptr_array_find_with_equal_func' [-Werror=implicit-function-declaration]
     if (g_ptr_array_find_with_equal_func (qtdemux->old_streams,
         ^
qtdemux.c:12531:5: error: nested extern declaration of 'g_ptr_array_find_with_equal_func' [-Werror=nested-externs]
     if (g_ptr_array_find_with_equal_func (qtdemux->old_streams,
     ^
cc1: all warnings being treated as errors
Makefile:796: recipe for target 'libgstisomp4_la-qtdemux.lo' failed
make[3]: *** [libgstisomp4_la-qtdemux.lo] Error 1
make[3]: Leaving directory '/opt/media/build/gst-plugins-good/gst/isomp4'
Makefile:908: recipe for target 'isomp4' failed
make[2]: *** [isomp4] Error 2
make[2]: Leaving directory '/opt/media/build/gst-plugins-good/gst'
Makefile:742: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/opt/media/build/gst-plugins-good'
Makefile:673: recipe for target 'all' failed
make: *** [all] Error 2

Compilation succeeds on Fedora 27, 28 and Ubuntu Bionic
Comment 1 U. Artie Eoff 2018-10-19 17:59:24 UTC
glib2.0-dev 2.48.2 package is newest available version on Ubuntu Xenial.

g_ptr_array_find_with_equal_func was not introduced until version 2.54.

https://github.com/GNOME/glib/blob/85e2a7d1b794e807bc003c0f2552555f793a193f/glib/garray.c#L1661
Comment 2 Tim-Philipp Müller 2018-10-19 18:13:51 UTC
Patch for this is in bug #797239
Comment 3 Sebastian Dröge (slomo) 2018-10-20 01:45:57 UTC
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 797239 ***