GNOME Bugzilla – Bug 797286
aom: Fails to build with AOM master
Last modified: 2018-10-15 17:49:41 UTC
../subprojects/gst-plugins-bad/ext/aom/gstav1enc.c: In function ‘gst_av1_enc_process’: ../subprojects/gst-plugins-bad/ext/aom/gstav1enc.c:360:36: error: ‘AOM_FRAME_IS_INVISIBLE’ undeclared (first use in this function); did you mean ‘AOM_FRAME_IS_INTRAONLY’? if ((pkt->data.frame.flags & AOM_FRAME_IS_INVISIBLE) != 0) ^~~~~~~~~~~~~~~~~~~~~~ AOM_FRAME_IS_INTRAONLY It looks like AOM_FRAME_IS_INVISIBLE macro got removed from libaom with that commit: https://aomedia.googlesource.com/aom/+/22043ef429129c886c03c122ac3f603901882809 So they broke API, I don't know if that should be reported as a bug on their side, or if we can update our side to work with new API?
Adding Sean DuBois in CC because he's listed as author of that code.
Created attachment 373931 [details] [review] aom: Fix build caused by API change in libaom AOM_FRAME_IS_INVISIBLE got removed by this commit: https://aomedia.googlesource.com/aom/+/22043ef429129c886c03c122ac3f603901882809
This was already resolved with one of the patches from #791674 commit cc9d65a512db89238e9b319b12262449e94097bb Author: Wonchul Lee <chul0812@gmail.com> Date: Wed Oct 3 17:13:32 2018 +0900 av1enc: fix compliation with removed defines AOM_FRAME_IS_INVISIBLE is unused and remove in aom_encoder.h https://aomedia-review.googlesource.com/c/aom/+/70421 https://bugzilla.gnome.org/show_bug.cgi?id=791674 *** This bug has been marked as a duplicate of bug 791674 ***