After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797272 - rtspconnection: do not duplicate authentication headers
rtspconnection: do not duplicate authentication headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.14.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-10 21:18 UTC by Mathieu Duponchelle
Modified: 2018-10-18 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtspconnection: do not duplicate authentication headers (1.65 KB, patch)
2018-10-10 21:18 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2018-10-10 21:18:21 UTC
See commit message
Comment 1 Mathieu Duponchelle 2018-10-10 21:18:27 UTC
Created attachment 373890 [details] [review]
rtspconnection: do not duplicate authentication headers

rtsp_connection_send takes care of adding those already,
and some reverse proxies such as nginx will reject the request
altogether if the Authorization header is present twice,
even with the same value.
Comment 2 Sebastian Dröge (slomo) 2018-10-11 09:19:43 UTC
Review of attachment 373890 [details] [review]:

There's send for the connection and for the watch. Are both always adding the auth header?

If yes, good to go
Comment 3 Mathieu Duponchelle 2018-10-11 12:55:36 UTC
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 373890 [details] [review] [review]:
> 
> There's send for the connection and for the watch. Are both always adding
> the auth header?
> 
> If yes, good to go

Yes, both will, in any case the messages here were only sent with rtsp_connection_send :)
Comment 4 Mathieu Duponchelle 2018-10-11 13:41:56 UTC
Attachment 373890 [details] pushed as aa6daaa - rtspconnection: do not duplicate authentication headers
Comment 5 Tim-Philipp Müller 2018-10-18 13:16:39 UTC
Also picked into 1.14.