After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797230 - video-overlay-composition: Handle miniobject writability correctly
video-overlay-composition: Handle miniobject writability correctly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-10-01 09:19 UTC by Sebastian Dröge (slomo)
Modified: 2018-10-01 17:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video-overlay-composition: Handle miniobject writability correctly (5.16 KB, patch)
2018-10-01 09:19 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-10-01 09:19:16 UTC 
See commit message
Comment 1 Sebastian Dröge (slomo) 2018-10-01 09:19:22 UTC 
Created attachment 373815 [details] [review]
video-overlay-composition: Handle miniobject writability correctly

By tracking parents and using the proper GstMiniObject API for detecting
writability instead of just the reference count.
Comment 2 Sebastian Dröge (slomo) 2018-10-01 09:21:03 UTC 
This does *not* handle correctly the case when there are multiple references to the buffer that contains the meta with a otherwise writable overlay composition.

We can't correctly set the parent-child relationship for the buffer->overlay composition because of the meta in between, and elements overwriting the overlay composition inside the meta directly without caring for anything.
Comment 3 Sebastian Dröge (slomo) 2018-10-01 16:26:25 UTC 
Attachment 373815 [details] pushed as bb0d58a - video-overlay-composition: Handle miniobject writability correctly