Created attachment 373677 [details] [review]
patch for this issue.

Review of attachment 373677 [details] [review]:

::: gst-libs/gst/vaapi/gstvaapidecoder_h265.c
@@ +1055,3 @@
   guint i, n_profiles = 0;
 
+  profile = gst_vaapi_utils_h265_get_profile (sps);

A function's signature change is not a good idea for a patch that is going to be backported to the stable branch.

Created attachment 373683 [details] [review]
libs: dec: h265: fix the macros used for IDC profile

profile_idc flag in SPS only indicate the IDC profile, which may
need some other flags together to get the real profile.

Attachment 373683 [details] pushed as f4f935b - libs: dec: h265: fix the macros used for IDC profile

For branch 1.14

* 3cdac1ed libs: dec: h265: fix the macros used for IDC profile

So just out of curiosity (writing release notes) - does this actually *fix* an issue, like decoding of some streams, or is it mostly a cleanup/code correctness patch? Hard to tell for me from the commit message and the bug here :)

(In reply to Tim-Philipp Müller from comment #6)
> So just out of curiosity (writing release notes) - does this actually *fix*
> an issue, like decoding of some streams, or is it mostly a cleanup/code
> correctness patch? Hard to tell for me from the commit message and the bug
> here :)

Just correctness :) so far the IDC enum matched with the profile, but with newer profiles it may not be the case