GNOME Bugzilla – Bug 797139
remove crumbs of library outside of gstreamer
Last modified: 2018-09-25 17:18:26 UTC
Since gstreamer-vaapi was merged into gstreamer project, the library was no longer "independent" of GStreamer. Still there are some crumbs of that, for example the usage of IN_LIBGSTVAAPI_CORE macro which makes not much sense nowadays, and, in my opinion, makes the code harder to follow. The following patches remove that macro usage.
Created attachment 373642 [details] [review] libs: remove dependency on IN_LIBGSTVAAPI_CORE This conditional code was when libgstvaapi was intended to be library used outside GStreamer. This not the case anymore, thus removing it.
Created attachment 373643 [details] [review] libs: videopool: remove unneeded code The removed code comes frome the bad practice of copy&paste. Better move it as internal function.
Created attachment 373644 [details] [review] libs: parser_frame: change macros for inlined functions
Created attachment 373645 [details] [review] libs: object: separation of internal API and plugins Removed exposed macros GST_VAAPI_OBJECT_DISPLAY() and GST_VAAPI_OBJECT_ID() to plugins, keeping them only for internal library usage. The purpose is readability.
Created attachment 373657 [details] [review] libs: remove dependency on IN_LIBGSTVAAPI_CORE This conditional code was when libgstvaapi was intended to be library used outside GStreamer. This not the case anymore, thus removing it.
Created attachment 373658 [details] [review] libs: videopool: remove unneeded code The removed code comes frome the bad practice of copy&paste. Better move it as internal function.
Created attachment 373659 [details] [review] libs: parser_frame: change macros for inlined functions
Created attachment 373660 [details] [review] libs: object: separation of internal API and plugins Removed exposed macros GST_VAAPI_OBJECT_DISPLAY() and GST_VAAPI_OBJECT_ID() to plugins, keeping them only for internal library usage. The purpose is readability.
Attachment 373657 [details] pushed as 4505acc - libs: remove dependency on IN_LIBGSTVAAPI_CORE Attachment 373658 [details] pushed as 0e16691 - libs: videopool: remove unneeded code Attachment 373659 [details] pushed as 9970e15 - libs: parser_frame: change macros for inlined functions Attachment 373660 [details] pushed as 0152410 - libs: object: separation of internal API and plugins