After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797103 - rtmp: Don't set debug callback of librtmp depending on debug level
rtmp: Don't set debug callback of librtmp depending on debug level
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-09-09 06:56 UTC by Seungha Yang
Modified: 2018-11-03 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtmp: Don't set debug callback of librtmp depending on debug level (1.06 KB, patch)
2018-09-09 06:57 UTC, Seungha Yang 		none Details | Review

Description Seungha Yang 2018-09-09 06:56:33 UTC 
When an application explicitly disable "rtmp" debug category,
don't hook debug callback of librtmp. The application might want
another debug callback instead of that of gstreamer.
Comment 1 Seungha Yang 2018-09-09 06:57:32 UTC 
Created attachment 373573 [details] [review]
rtmp: Don't set debug callback of librtmp depending on debug level
Comment 2 Tim-Philipp Müller 2018-09-09 12:59:29 UTC 
Well, debug categories can be enabled at runtime, in which case this wouldn't work any longer.

It's also a big unexpected really, I think one wouldn't expect the application to use librtmp directly as well. How/why are you using it?
Comment 3 Seungha Yang 2018-09-09 13:29:57 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> Well, debug categories can be enabled at runtime, in which case this
> wouldn't work any longer.
> 
> It's also a big unexpected really, I think one wouldn't expect the
> application to use librtmp directly as well. How/why are you using it?

My server side application actually uses both librtmp directly and also rtmpsink in the identical process actually :( To pull rtmp packet from remote, I uses librtmp directly with customized rtmp packet handler, but the handler is not suitable to be implemented in rtmpsrc.

The problem is gstreamer rtmp plugin replaces already installed librtmp debug callback regardless of "rtmp" debug level.
Comment 4 GStreamer system administrator 2018-11-03 14:31:16 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/782.