After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797045 - glbasefilter: Add proper support for in-place transform
glbasefilter: Add proper support for in-place transform
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-08-29 14:46 UTC by Nicolas Dufresne (ndufresne)
Modified: 2018-08-30 15:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Nicolas Dufresne (ndufresne) 2018-08-29 14:46:03 UTC 
In 1.15 we introduced gst_gl_base_filter_find_gl_context(), which let base subclass trigger the query for a context, and will call gl_stop/gl_start, though using this is a bit difficult, and still requires a lot of work when a filter sets base transform to in-place mode.

We should detect that the transform is in-place and trigger the calls to gl_start/gl_stop/gl_setcaps() at appropriate places. This is not triggered because there is no decide_allocation() in that mode.
Comment 1 Nicolas Dufresne (ndufresne) 2018-08-30 15:23:48 UTC 
As pointed out by Matthew:
https://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/gst-libs/gst/gl/gstglbasefilter.c#n204