After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 797015 - DHCP: NM doesn't check DHCP lease on DHCP timeout
DHCP: NM doesn't check DHCP lease on DHCP timeout
Status: RESOLVED OBSOLETE
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2018-08-23 07:11 UTC by Jonathan Kang
Modified: 2020-11-12 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
device: don't fail dhcp directly on timeout (3.36 KB, patch)
2018-09-17 07:36 UTC, Jonathan Kang
none Details | Review
dhcp: separate timeout function call with watch call (2.13 KB, patch)
2018-09-18 08:43 UTC, Jonathan Kang
none Details | Review

Description Jonathan Kang 2018-08-23 07:11:57 UTC
If the DHCP server is down and client reboot during the server down time, client
won't be able to get a valid ip address, even though the DHCP lease is still
valid.

But "man dhclient-script" says:
> TIMEOUT
> The  DHCP  client  has  been  unable  to contact any DHCP servers.  However,
> an old lease has been identified, and its parameters have been passed in
> as with BOUND.   The client configuration script should test these
> parameters and, if it has reason to believe they are valid, should exit
> with a value of zero.   If not, it should exit with a nonzero value.

NetworkManager needs to better handle the timeout reason instead of just fail
it directly.
Comment 1 Jonathan Kang 2018-09-17 07:36:31 UTC
Created attachment 373670 [details] [review]
device: don't fail dhcp directly on timeout

This is one of the patches needed for fixing bug.

We should also improve the way we consider it's a dhcp timeout. Currently we
simply use a timeout function(45 seconds by default) and fail it directly.
Comment 2 Jonathan Kang 2018-09-18 08:43:16 UTC
Created attachment 373680 [details] [review]
dhcp: separate timeout function call with watch call
Comment 3 André Klapper 2020-11-12 14:28:08 UTC
bugzilla.gnome.org is being shut down in favor of a GitLab instance. 
We are closing all old bug reports and feature requests in GNOME Bugzilla which have not seen updates for a long time.

If you still use NetworkManager and if you still see this bug / want this feature in a recent and supported version of NetworkManager, then please feel free to report it at https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/

Thank you for creating this report and we are sorry it could not be implemented (workforce and time is unfortunately limited).