After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796837 - rtpL8pay: don't try to modify a read-only structure
rtpL8pay: don't try to modify a read-only structure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.14.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-07-19 15:44 UTC by Michael Olbrich
Modified: 2018-07-25 13:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpL8pay: don't try to modify a read-only structure (1.40 KB, patch)
2018-07-19 15:44 UTC, Michael Olbrich 		committed Details | Review

Description Michael Olbrich 2018-07-19 15:44:37 UTC 
I noticed this when gst_structure_remove_field() killed my application when
fatal-criticals was enabled.
I'm not sure what the code was supposed to do exactly. It has no effect
right now, so just removing it makes sense to me.
Comment 1 Michael Olbrich 2018-07-19 15:44:43 UTC 
Created attachment 373094 [details] [review]
rtpL8pay: don't try to modify a read-only structure

Just remove the code. It's not doing anything useful anyways. The modified
caps are the result of a caps query, so either not used afterwards of a
reference to some internal caps of another element that should not be
modified.
Comment 2 Nicolas Dufresne (ndufresne) 2018-07-19 18:02:51 UTC 
Review of attachment 373094 [details] [review]:

This is correct. I bet the intention was to remove the channel field from the returned caps, but they did it wrong. I'm not sure removing that field from the returned caps is really needed, we'll return the template which is already a range from 1 to "infinity".
Comment 3 Nicolas Dufresne (ndufresne) 2018-07-19 18:07:51 UTC 
Attachment 373094 [details] pushed as bd05ab8 - rtpL8pay: don't try to modify a read-only structure