GNOME Bugzilla – Bug 796833
gl: Add configuration switches for turning on/off features with external dependencies
Last modified: 2018-08-01 04:52:43 UTC
Currently, support for GBM, libpng, libjpeg is enabled by autodetecting these packages. Build frameworks like OpenEmbedded however are tailored for customizing builds and allowing them to be as small as possible to fit in a small firmware image. To that end, these frameworks require that it must be possible to explicitely enable/disable such features to guarantee deterministic builds. Deterministic builds however won't be possible with uncontrolled autodetection. If for example libpng happens to be around in build #1 (because some other package required it for example), then suddenly gst-plugins-base supports libpng. To fix that, add --enable switches for png, jpeg, gbm.
Created attachment 373090 [details] [review] enable-gbm switch patch
Created attachment 373091 [details] [review] enable-jpeg and enable-png switches patch
Review of attachment 373090 [details] [review]: Not quite :) ::: m4/gst-gl.m4 @@ +182,3 @@ fi + if test "x$HAVE_EGL" = "xyes" -a "x$NEED_GBM" != "xno"; then This condition needs to be reversed and separated to ask if gbm was explicitly asked for and then error out if EGL wasn't found or was disabled. i.e. --enable-gbm --disable-egl should error.
Review of attachment 373091 [details] [review]: Looks good
Created attachment 373138 [details] [review] enable-gbm switch patch v2
commit 5576475e0fa8acefc6a17adb1214817abceed548 Author: Carlos Rafael Giani <dv@pseudoterminal.org> Date: Thu Jul 19 11:16:05 2018 +0200 gl: Add switches for explicitely enabling/disabling PNG and JPEG support https://bugzilla.gnome.org/show_bug.cgi?id=796833 commit ad298cf5f57b1e5dacb3d15065bed30ae3f528e7 Author: Carlos Rafael Giani <dv@pseudoterminal.org> Date: Thu Jul 19 10:30:54 2018 +0200 gl: Add switch for explicitely enabling/disabling GBM support https://bugzilla.gnome.org/show_bug.cgi?id=796833