GNOME Bugzilla – Bug 796742
audio: remove the non-interleaved layout from the caps of elements that do not actually support this
Last modified: 2018-11-03 12:08:42 UTC
A lot of elements claim to be supporting non-interleaved audio, but they actually don't, it's broken. I'm going to go through all elements and remove this claim unless it's trivial to fix them. This bug will work as a tracker.
Created attachment 372933 [details] [review] adder: remove non-interleaved layout from caps
Comment on attachment 372933 [details] [review] adder: remove non-interleaved layout from caps Adder is also deprecated for all practical purposes :)
commit a498d3fe6e2bedd2e1622bb51811d44c8fabd6ed Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Mon Feb 12 15:33:49 2018 +0200 adder: remove non-interleaved layout from caps adder needs more than just trivial work to support planar buffers properly because it currently reads sub-buffers from GstCollectPads in order for all of them to have matching sizes. In planar mode, this means it would truncate some channels and mix them up in strange ways. It only works if all input buffers in all sink pads have matching sizes.
Other elements that need love: gst-plugins-base: * complex case, not sure if it works... - rawaudioparse * claims non-interleaved support on big endian arch only ?!: - volume * should take care of potential clipping that is denoted only on the GstAudioMeta: - audiointerleave gst-plugins-good: * filters, most likely work, because they operate on each sample individually, in place: - audioamplify - audiodynamic - audioinvert - rglimiter * should take care of potential clipping that is denoted only on the GstAudioMeta: - interleave * should add GstAudioMeta on the output if necessary: - deinterleave - qtdemux
(In reply to George Kiagiadakis from comment #4) > * claims non-interleaved support on big endian arch only ?!: > - volume Should support it just fine as long as it doesn't do the per-sample volume based on the controller.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/469.