After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796740 - gst_audio_buffer_clip: support non-interleaved buffers
gst_audio_buffer_clip: support non-interleaved buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 751605
Blocks: 705977 796741
 
 
Reported: 2018-07-03 13:06 UTC by George Kiagiadakis
Modified: 2018-07-12 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libs: audio: implement support for non-interleaved audio in gst_audio_buffer_clip() (4.58 KB, patch)
2018-07-03 13:06 UTC, George Kiagiadakis
none Details | Review
tests: audio: add unit tests for planar audio support in gst_audio_buffer_clip() (8.42 KB, patch)
2018-07-03 13:07 UTC, George Kiagiadakis
none Details | Review
libs: audio: add a new gst_audio_buffer_truncate() function (5.10 KB, patch)
2018-07-03 13:08 UTC, George Kiagiadakis
none Details | Review

Description George Kiagiadakis 2018-07-03 13:06:37 UTC
Created attachment 372929 [details] [review]
libs: audio: implement support for non-interleaved audio in gst_audio_buffer_clip()

Follow up from bug 751605
Comment 1 George Kiagiadakis 2018-07-03 13:07:09 UTC
Created attachment 372930 [details] [review]
tests: audio: add unit tests for planar audio support in gst_audio_buffer_clip()
Comment 2 George Kiagiadakis 2018-07-03 13:08:00 UTC
Created attachment 372931 [details] [review]
libs: audio: add a new gst_audio_buffer_truncate() function

This moves the truncation logic out of gst_audio_buffer_clip() so that it can be used in other places. I need this to fix audiorate.
Comment 3 George Kiagiadakis 2018-07-12 09:15:19 UTC
commit b33d70e97ff1679de5b9f85155693afe9912afd9
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Fri May 18 16:22:47 2018 +0300

    libs: audio: add a new gst_audio_buffer_truncate() function
    
    Essentially this moves the truncation logic out of gst_audio_buffer_clip()
    so that it can be used in other places, like in audiorate.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796740

commit adf48c9d3bcb384da44a961f6e5eb4e8fad74d9b
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Fri May 18 16:22:32 2018 +0300

    tests: audio: add unit tests for planar audio support in gst_audio_buffer_clip()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796740

commit 9cb09e7269d2bbe42adc389f895dd5c2eb9cf8df
Author: George Kiagiadakis <george.kiagiadakis@collabora.com>
Date:   Thu Feb 8 14:34:23 2018 +0200

    libs: audio: implement support for non-interleaved audio in gst_audio_buffer_clip()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796740