After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796694 - gl (gbm backend): typo when checking for gbm platform extension
gl (gbm backend): typo when checking for gbm platform extension
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-27 14:00 UTC by memeka
Modified: 2018-06-28 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix typo when checking for gbm platform extension (927 bytes, patch)
2018-06-27 14:00 UTC, memeka 		none Details | Review
typo patch (fixed) (1.05 KB, patch)
2018-06-28 04:41 UTC, memeka 		committed Details | Review

Description memeka 2018-06-27 14:00:37 UTC 
Created attachment 372853 [details] [review]
fix typo when checking for gbm platform extension

gst_gl_check_extension ("EGL_MESA_platform_gbm", egl_exts) ||
gst_gl_check_extension ("EGL_MESA_platform_gbm", egl_exts))

typo: second check should be for EGL_KHR_platform_gbm
Comment 1 Matthew Waters (ystreet00) 2018-06-28 01:41:21 UTC 
Do you want to make a patch? :)
Comment 2 memeka 2018-06-28 03:34:00 UTC 
(In reply to Matthew Waters (ystreet00) from comment #1)
> Do you want to make a patch? :)

Patch is attached...
Comment 3 Matthew Waters (ystreet00) 2018-06-28 04:09:17 UTC 
(In reply to memeka from comment #2)
> (In reply to Matthew Waters (ystreet00) from comment #1)
> > Do you want to make a patch? :)
> 
> Patch is attached...

git am doesn't like that.

Could you attach a 'git format-patch' patch please? :)
Comment 4 memeka 2018-06-28 04:41:11 UTC 
Created attachment 372858 [details] [review]
typo patch (fixed)

Added new patch created with git-format-patch
Comment 5 Matthew Waters (ystreet00) 2018-06-28 13:54:51 UTC 
commit 1c8bf44dea2af3b8bbed3e230479fe5405a5bad6
Author: memeka <mihailescu2m@gmail.com>
Date:   Tue Jun 26 12:18:27 2018 +0930

    gl: check for EGL_KHR_platform_gbm for non-MESA gbm implementations
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796694