Created attachment 372825 [details] [review]
adds AV1 support to gstivfparse.c

with this patch bascially adds the AV01 FOURCC to the list of allowed IVF Media.

At a later point dynamic resolution change can be supported - therefore the sequence header OBU and frame header OBU of AV1 file must be parsed - which can be done in future with the help of gst-lib gstav1parse.

Comment on attachment 372825 [details] [review]
adds AV1 support to gstivfparse.c

Makes sense but please provide this as a "git format-patch" style patch :) See https://gstreamer.freedesktop.org/documentation/contribute/index.html#how-to-submit-patches

Created attachment 372834 [details] [review]
add AV1 support to gstivfparse.c

using proper git format-patch

(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 372825 [details] [review] [review]
> adds AV1 support to gstivfparse.c
> 
> Makes sense but please provide this as a "git format-patch" style patch :)
> See
> https://gstreamer.freedesktop.org/documentation/contribute/index.html#how-to-
> submit-patches

thanks for the feedback

Review of attachment 372834 [details] [review]:

for sake of good practices, the subject line should have the format:

element: description

Also, the subject should have a recommended length of 50 chars and the body should wrap at 72 chars:

https://chris.beams.io/posts/git-commit/#seven-rules

Finally, at the end of the commit log, it should be the URL of this bug, for further reference.

Created attachment 372848 [details] [review]
adds AV1 support to gstivfparse.c

(In reply to Víctor Manuel Jáquez Leal from comment #5)
> Review of attachment 372834 [details] [review] [review]:
> 
> for sake of good practices, the subject line should have the format:
> 
> element: description
> 
> Also, the subject should have a recommended length of 50 chars and the body
> should wrap at 72 chars:
> 
> https://chris.beams.io/posts/git-commit/#seven-rules
> 
> Finally, at the end of the commit log, it should be the URL of this bug, for
> further reference.

thanks for this hint

Comment on attachment 372848 [details] [review]
adds AV1 support to gstivfparse.c

Looks good, I'll merge that later. Thanks a lot! :)

commit 71c5eae508dee9cc2d960682ef45066e8c1227d8 (HEAD -> master)
Author: Georg Ottinger <g.ottinger@gmx.at>
Date:   Tue Jun 26 17:45:36 2018 +0200

    ivfparse: Add the AV01 FOURCC for parsing AV1 IVFs
    
    Adds AV01 FOURCC to the list of allowed media files, in order to allow
    parsing the IVF Container holding AV1 content.
    At a later point dynamic resolution change can be supported - therefore
    the sequence header OBU and frame header OBU of AV1 file must be parsed,
    which can be done in future with the help of gst-lib gstav1parse.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796677

Nice! Thanks for your work on this.