Created attachment 372695 [details] [review]
pitch: Fix single input buffer followed by EOS

The flush function immediately returned when pitch->next_buffer_offset
was 0.

This is clearly wrong, as next_buffer_offset can be 0 when a single
input buffer has been received, and no output buffer has been produced
before receiving EOS.

Simply remove that condition.

Created attachment 372696 [details] [review]
pitch: fix latency reporting

When max is GST_CLOCK_TIME_NONE in the query, it should not
be set in the query handler, this otherwise could lead to
impossible situations, where the minimum latency ended up
greater than the maximum.

Created attachment 372697 [details] [review]
pitch: preserve seek event seqnums

This was wreaking havoc when used with a downstream audiomixer.

Review of attachment 372696 [details] [review]:

OK, just keep previous max latency if we do not have a value for it, lgtm

Review of attachment 372697 [details] [review]:

lgtm

Review of attachment 372695 [details] [review]:

Looking at the code that condition indeed doesn't make sense to me. This patch makes sense to me.

Attachment 372695 [details] pushed as 5f020be - pitch: Fix single input buffer followed by EOS
Attachment 372696 [details] pushed as 0b03b47 - pitch: fix latency reporting
Attachment 372697 [details] pushed as 44f0814 - pitch: preserve seek event seqnums