After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796570 - Android tutorials: add gradle build system
Android tutorials: add gradle build system
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-12 16:51 UTC by Mathieu Duponchelle
Modified: 2018-06-14 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Android tutorials: add android top-level folder (36.79 KB, patch)
2018-06-12 16:51 UTC, Mathieu Duponchelle
committed Details | Review
Android tutorials: add gradle build system (88.14 KB, patch)
2018-06-12 16:52 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2018-06-12 16:51:54 UTC
Based on the android player example in gst-examples
Comment 1 Mathieu Duponchelle 2018-06-12 16:51:59 UTC
Created attachment 372660 [details] [review]
Android tutorials: add android top-level folder

This in preparation for the next commit, adding gradle as a
build system
Comment 2 Mathieu Duponchelle 2018-06-12 16:52:06 UTC
Created attachment 372661 [details] [review]
Android tutorials: add gradle build system
Comment 3 Sebastian Dröge (slomo) 2018-06-13 07:14:44 UTC
Comment on attachment 372660 [details] [review]
Android tutorials: add android top-level folder

Good idea independent of anything else
Comment 4 Sebastian Dröge (slomo) 2018-06-13 07:18:39 UTC
Review of attachment 372661 [details] [review]:

Looks mostly good, just fix the below and merge :)

::: examples/tutorials/android/android-tutorial-5/build.gradle
@@ +30,3 @@
+
+                // All archs except MIPS and MIPS64 are supported
+                abiFilters  'armeabi-v7a', 'arm64-v8a', 'x86'

Should stop building armeabi (non-v7a) for the 1.15/1.16 releases

::: markdown/installing/for-android-development.md
@@ +206,3 @@
+```bash
+$ cd examples/tutorials/android
+$ GSTREAMER_ROOT_ANDROID=/path/to/gst-android-1.14/ PATH=~/dev/android/tools/bin:~/dev/android/ndk-bundle:$PATH ANDROID_HOME="$HOME/dev/android/" ./gradlew :android-tutorial-1:installDebug

Should always put the path into gradle.properties instead. Environment variables are awkward for Windows users.

Maybe also add an paragraph for how to do all this in Android Studio?

@@ -195,0 +195,18 @@
+#### Using gradle from the command-line
+
+To build and deploy the tutorials to your device, use a command similar to:
... 15 more ...

Or alternatively just start the app from the app launcher on the device :)
Comment 5 Mathieu Duponchelle 2018-06-13 23:44:05 UTC
(In reply to Sebastian Dröge (slomo) from comment #4)

> Should stop building armeabi (non-v7a) for the 1.15/1.16 releases

Fixed the rest of the points, but I don't get this one, if I leave armeabi in there it simply doesn't build with gradle I'm afraid :)
Comment 6 Sebastian Dröge (slomo) 2018-06-14 05:12:32 UTC
(In reply to Mathieu Duponchelle from comment #5)
> (In reply to Sebastian Dröge (slomo) from comment #4)
> 
> > Should stop building armeabi (non-v7a) for the 1.15/1.16 releases
> 
> Fixed the rest of the points, but I don't get this one, if I leave armeabi
> in there it simply doesn't build with gradle I'm afraid :)

Nothing for you to do here. I meant we should drop armeabi from the cerbero build so that it is not included in the binaries anymore.
Comment 7 Mathieu Duponchelle 2018-06-14 15:23:19 UTC
(In reply to Sebastian Dröge (slomo) from comment #6)
> Nothing for you to do here. I meant we should drop armeabi from the cerbero
> build so that it is not included in the binaries anymore.

OK got it, pushing then, thanks!
Comment 8 Mathieu Duponchelle 2018-06-14 15:25:34 UTC
Attachment 372660 [details] pushed as 225c23f - Android tutorials: add android top-level folder
Attachment 372661 [details] pushed as 82dd7c3 - Android tutorials: add gradle build system