Created attachment 372636 [details] [review]
sdp: Add new constructor, sdp_message_from_text

Review of attachment 372636 [details] [review]:

lgtm, although you might want to mention why exactly this is needed.

Review of attachment 372636 [details] [review]:

There is a win32 def file that still need to be updated.

::: gst-libs/gst/sdp/gstsdpmessage.c
@@ +244,3 @@
+ * Parse @text and create a new SDPMessage from these.
+ *
+ * Returns: a #GstSDPResult.

Since marker is missing.

Attachment 372636 [details] pushed as a4a27fd - sdp: Add new constructor, sdp_message_from_text

Did you choose _new_from_text() on purpose, vs. the more common _new_from_string() ?

(In reply to Tim-Philipp Müller from comment #5)
> Did you choose _new_from_text() on purpose, vs. the more common
> _new_from_string() ?

I did yes, there's an as_text() method in GstSDPMessage

(In reply to Nicolas Dufresne (ndufresne) from comment #3)
> Review of attachment 372636 [details] [review] [review]:
> 
> There is a win32 def file that still need to be updated.

There's no def file in -base

> 
> ::: gst-libs/gst/sdp/gstsdpmessage.c
> @@ +244,3 @@
> + * Parse @text and create a new SDPMessage from these.
> + *
> + * Returns: a #GstSDPResult.
> 
> Since marker is missing.

Ah, I hadn't updated the patch here it seems, the commited version has the marker :)