After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796389 - gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop
gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 796390 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-05-24 16:39 UTC by Alicia Boya García
Modified: 2018-05-25 11:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop (2.54 KB, patch)
2018-05-24 16:48 UTC, Alicia Boya García
none Details | Review
gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop (2.54 KB, patch)
2018-05-25 10:19 UTC, Alicia Boya García
committed Details | Review

Description Alicia Boya García 2018-05-24 16:39:42 UTC
This patch modifies the default behavior of --gdb to not run and quit
automatically the debugee, but rather wait for user input. This is
usually much more convenient to debug all kinds of bugs.

The automatic run behavior has been moved to a new command switch:
--gdb-non-stop
Comment 1 Alicia Boya García 2018-05-24 16:47:18 UTC
*** Bug 796390 has been marked as a duplicate of this bug. ***
Comment 2 Alicia Boya García 2018-05-24 16:48:34 UTC
Created attachment 372392 [details] [review]
gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop

This patch modifies the default behavior of --gdb to not run and quit
automatically the debugee, but rather wait for user input. This is
usually much more convenient to debug all kinds of bugs.

The automatic run behavior has been moved to a new command switch:
--gdb-non-stop
Comment 3 Thibault Saunier 2018-05-24 16:51:58 UTC
Review of attachment 372392 [details] [review]:

::: validate/launcher/main.py
@@ +460,3 @@
                         action="store_true",
                         help="Run the tests inside gdb (implies"
                         " --output-dir=stdout and --jobs=1)")

Is the test timeout UNLIMITED when this is used?

@@ +463,3 @@
+    parser.add_argument("--gdb-non-stop", dest="gdb_non_stop",
+                        action="store_true",
+                        help="Run the debugee automatically in gdb (implies --gdb)")

debugee? "tests" ?
Comment 4 Thibault Saunier 2018-05-24 16:51:59 UTC
Review of attachment 372392 [details] [review]:

::: validate/launcher/main.py
@@ +460,3 @@
                         action="store_true",
                         help="Run the tests inside gdb (implies"
                         " --output-dir=stdout and --jobs=1)")

Is the test timeout UNLIMITED when this is used?

@@ +463,3 @@
+    parser.add_argument("--gdb-non-stop", dest="gdb_non_stop",
+                        action="store_true",
+                        help="Run the debugee automatically in gdb (implies --gdb)")

debugee? "tests" ?
Comment 5 Alicia Boya García 2018-05-25 10:19:19 UTC
Created attachment 372398 [details] [review]
gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop

This patch modifies the default behavior of --gdb to not run and quit
automatically the test, but rather wait for user input. This is
usually much more convenient to debug all kinds of bugs.

The automatic run behavior has been moved to a new command switch:
--gdb-non-stop
Comment 6 Thibault Saunier 2018-05-25 11:00:25 UTC
Attachment 372398 [details] pushed as 2c32ccd - gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop