GNOME Bugzilla – Bug 796387
Update webrtctransceiver example to use multiple streams
Last modified: 2018-11-03 14:24:10 UTC
Created attachment 372389 [details] modified example (adds an audio stream and checks caps) I've noticed that my recvonly webrtcbin application breaks once I enabled the new ULPFEC/RED features. it's really easy to reproduce with this modified example of webrtctransceiver.c it works when commenting out the ULPFEC/RED features. if they're enabled, the pad-added callback asserts because the pad's CAPS aren't fully set.
Created attachment 372391 [details] [review] Adds an audio stream and checks caps
Created attachment 372441 [details] [review] webrtcbin: copy sticky events for new pads This patch from Mathieu fixes the issue for me
Created attachment 372442 [details] [review] webrtc: Add audio to stream. Test case for bug #796387
I have merged my patch as 33c7af8845c9f53c21c0c3f8ca20e26b58346317 , I have renamed this bug as I think we could merge the updated example as well, my only requirement for it would be to make sure FEC is only used for the video stream, this would make the example more generally useful :)
(In reply to Mathieu Duponchelle from comment #4) > I have merged my patch as 33c7af8845c9f53c21c0c3f8ca20e26b58346317 , I have > renamed this bug as I think we could merge the updated example as well, my > only requirement for it would be to make sure FEC is only used for the video > stream, this would make the example more generally useful :) Cherry-pick to 1.14 for 1.14.2. I guess the test-case change is still pending?
(In reply to Jan Schmidt from comment #5) > I guess the test-case change is still pending? Not sure, Andreas ?
I couldn't figure out how to determine whether a transceiver was for the video or the audio stream. there's no CAPS set anywhere visible at the point :/
(In reply to Andreas Frisch from comment #7) > I couldn't figure out how to determine whether a transceiver was for the > video or the audio stream. there's no CAPS set anywhere visible at the point > :/ You would need to look at the SDP and compare with the transceiver's index iirc
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/716.