After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796385 - test_paths: Reindent to avoid tripping -Wmisleading-indentation
test_paths: Reindent to avoid tripping -Wmisleading-indentation
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-05-24 12:02 UTC by Iain Lane
Modified: 2018-05-30 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test_paths: Reindent to avoid tripping -Wmisleading-indentation (1.89 KB, patch)
2018-05-24 12:02 UTC, Iain Lane 		none Details | Review

Description Iain Lane 2018-05-24 12:02:28 UTC 
This was introduced by b9b642de06e714584e89aa7b8d878a98599538ed
Comment 1 Iain Lane 2018-05-24 12:02:33 UTC 
Created attachment 372383 [details] [review]
test_paths: Reindent to avoid tripping -Wmisleading-indentation

This fixes:

glib/tests/testglib.c: In function ‘test_paths’:
glib/tests/testglib.c:955:3: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
   if (g_test_verbose ())
   ^~
glib/tests/testglib.c:958:5: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
     {
     ^
Comment 2 Christoph Reiter (lazka) 2018-05-30 07:58:52 UTC 
Looks like this bug was created right during our gitlab migration last week.

Can you open a MR with your patch over at https://gitlab.gnome.org/GNOME/glib/merge_requests ? Or file an issue?

Thanks!
Comment 3 Philip Withnall 2018-05-30 09:15:38 UTC 
Thanks Iain! I’ve attached your patch as an MR here: https://gitlab.gnome.org/GNOME/glib/merge_requests/42

Let’s close this bug and track progress on the MR instead.