GNOME Bugzilla – Bug 796213
Meson: Fail to build on macosx
Last modified: 2018-05-18 14:11:09 UTC
Meson sets warning flags project wide, which is a good thing, but that means gio/kqueue fails to build with meson because of -Wdeclaration-after-statement on macos.
Created attachment 372157 [details] [review] kqueue: Fix -Wdeclaration-after-statement errors
The good news is that was the only build issue I got when building on macos using GStreamer's cerbero. Did not try to run it thought.
Review of attachment 372157 [details] [review]: Feel free to push with this change. Thanks for catching all this. :-) ::: gio/kqueue/dep-list.c @@ +171,3 @@ DIR *dir = opendir (path); + + assert (path != NULL); This assert() is no longer effective, since `path` is used before it now (with the opendir(path) call on the line above). That opendir() call needs to be moved below the assert().
Created attachment 372186 [details] [review] kqueue: Fix -Wdeclaration-after-statement errors
Attachment 372186 [details] pushed as 5b19df2 - kqueue: Fix -Wdeclaration-after-statement errors