After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795555 - Use get_introspection_module to get the module object
Use get_introspection_module to get the module object
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
1.13.90
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-25 17:47 UTC by Emilio Pozuelo Monfort
Modified: 2018-04-28 07:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overrides: use get_introspection_module (1.47 KB, patch)
2018-04-25 17:50 UTC, Emilio Pozuelo Monfort 		committed Details | Review

Description Emilio Pozuelo Monfort 2018-04-25 17:47:07 UTC 
The pygobject overrides should use get_introspection_module rather than poking at the modules list directly. It's way cleaner, and accessing the list directly is not reliable as the object may not be defined yet. Patch coming.

https://gitlab.gnome.org/GNOME/pygobject/commit/e9624ed1d38c777de2b430e3b0fbae2acbf34956
https://bugs.debian.org/896241
Comment 1 Emilio Pozuelo Monfort 2018-04-25 17:50:36 UTC 
Created attachment 371399 [details] [review]
overrides: use get_introspection_module

Btw this seems to be available since pygobject 3.8. Maybe it's time to bump the requirement?
Comment 2 Thibault Saunier 2018-04-25 18:14:15 UTC 
Attachment 371399 [details] pushed as e84b9b0 - overrides: use get_introspection_module
Comment 3 Thibault Saunier 2018-04-25 18:14:44 UTC 
Also bumped the dependency
Comment 4 Sebastian Dröge (slomo) 2018-04-28 07:36:00 UTC 
Backported both to 1.14 as it breaks the bindings on Debian at least, so probably widely causes problems