After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795419 - x265enc: Make sure sinkpad caps are never renegotiated while runnning
x265enc: Make sure sinkpad caps are never renegotiated while runnning
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 795420
 
 
Reported: 2018-04-20 20:29 UTC by Thibault Saunier
Modified: 2018-11-03 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x265enc: Make sure sinkpad caps are never renegotiated while runnning (1.46 KB, patch)
2018-04-20 20:30 UTC, Thibault Saunier 		rejected Details | Review

Description Thibault Saunier 2018-04-20 20:29:57 UTC 
See commit message.
Comment 1 Thibault Saunier 2018-04-20 20:30:03 UTC 
Created attachment 371176 [details] [review]
x265enc: Make sure sinkpad caps are never renegotiated while runnning

This is not supported and we should NNE if upstream is not able to
handle that restriction.
Comment 2 Sebastian Dröge (slomo) 2018-04-21 10:36:24 UTC 
In bytestream mode this should work just fine, or not? And in avc mode as long as downstream supports it. qtmux could support it but does not, matroskamux can't support it, for others I don't know.

You would basically have to drain and then recreate the encoder.
Comment 3 Thibault Saunier 2018-04-21 11:54:53 UTC 
Here I am fixing a bug where we advert as being able to renegotiate but the feature is not implemented, later on we can implement it, sure.
Comment 4 Thibault Saunier 2018-04-22 23:49:48 UTC 
Rejecting that patch as renegotation is not as fundamentally broken as I first had the impression (more details in https://bugzilla.gnome.org/show_bug.cgi?id=795416#c4)
Comment 5 GStreamer system administrator 2018-11-03 14:21:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/692.