After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795382 - [Ubuntu 14.04] Build failure due to commit 4984af5917b
[Ubuntu 14.04] Build failure due to commit 4984af5917b
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-19 19:22 UTC by jayeshece08
Modified: 2018-04-20 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
testsrcbin: Do not use G_DECLARE_ as it requires GLib 2.44 (1.24 KB, patch)
2018-04-20 00:08 UTC, Thibault Saunier
committed Details | Review

Description jayeshece08 2018-04-19 19:22:28 UTC
gst-plugins-bad fails on Ubuntu 14.04 with glibc version 2.40.2-0ubuntu1
https://packages.ubuntu.com/search?suite=trusty-updates&section=all&arch=any&keywords=libglib2.0-dev&searchon=names

failure snip:
14:18:05,353 INFO  - libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../.. -I/opt/media/install/include -pthread -I/opt/media/install/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -DGST_USE_UNSTABLE_API -fno-strict-aliasing -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -Werror -g -DGST_DISABLE_DEPRECATED -fvisibility=hidden -pthread -I/opt/media/install/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread -I/opt/media/install/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g3 -MT libgstfreeverb_la-gstfreeverb.lo -MD -MP -MF .deps/libgstfreeverb_la-gstfreeverb.Tpo -c gstfreeverb.c -fPIC -DPIC -o .libs/libgstfreeverb_la-gstfreeverb.o
14:18:05,376 INFO  - gsttestsrcbin.c:56:5: error: expected ')' before 'GstBin'
14:18:05,376 INFO  - GstBin);
14:18:05,376 INFO  - ^
14:18:05,376 INFO  - gsttestsrcbin.c: In function 'gst_test_src_bin_uri_handler_get_uri':
14:18:05,376 INFO  - gsttestsrcbin.c:94:3: error: unknown type name 'GstTestSrcBin'
14:18:05,376 INFO  - GstTestSrcBin *self = GST_TEST_SRC_BIN (handler);
14:18:05,376 INFO  - ^
14:18:05,376 INFO  - gsttestsrcbin.c:94:3: error: implicit declaration of function 'GST_TEST_SRC_BIN' [-Werror=implicit-function-declaration]


Its due to : https://github.com/GStreamer/gst-plugins-bad/blob/4984af5917b343ec65270ed3e673228de1b70fa7/gst/debugutils/gsttestsrcbin.c#L55 which uses G_DECLARE_FINAL_TYPE which was released as part of https://github.com/GNOME/glib/releases/tag/2.44.1 on  May 12, 2015 bypassing ubuntu 14.04

Bad commit: https://github.com/GStreamer/gst-plugins-bad/blob/4984af5917b343ec65270ed3e673228de1b70fa7

https://developer.gnome.org/gobject/2.44/api-index-2-44.html had introduced G_DECLARE_FINAL_TYPE
Comment 1 Thibault Saunier 2018-04-20 00:08:33 UTC
Created attachment 371146 [details] [review]
testsrcbin: Do not use G_DECLARE_ as it requires GLib 2.44

Fixes
Comment 2 Thibault Saunier 2018-04-20 00:11:26 UTC
Attachment 371146 [details] pushed as 5bc3681 - testsrcbin: Do not use G_DECLARE_ as it requires GLib 2.44