After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795213 - meson: install gdk-pixbuf-marshal.h
meson: install gdk-pixbuf-marshal.h
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-12 22:34 UTC by Jeremy Bicha
Modified: 2018-04-25 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: install gdk-pixbuf-marshal.h (686 bytes, patch)
2018-04-12 22:35 UTC, Jeremy Bicha 		rejected Details | Review
meson: Install the marshalers header (1.20 KB, patch)
2018-04-25 15:35 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Jeremy Bicha 2018-04-12 22:34:55 UTC 
This file was missing compared to the autotools build
Comment 1 Jeremy Bicha 2018-04-12 22:35:01 UTC 
Created attachment 370876 [details] [review]
meson: install gdk-pixbuf-marshal.h
Comment 2 Emmanuele Bassi (:ebassi) 2018-04-25 15:34:42 UTC 
Review of attachment 370876 [details] [review]:

gdk-pixbuf-marshal.h is generated by gnome.genmarshal(), so it cannot be included inside the installed headers list.

The gnome.genmarshal() has an `install_header` parameter that should be set to true.
Comment 3 Emmanuele Bassi (:ebassi) 2018-04-25 15:35:54 UTC 
Created attachment 371388 [details] [review]
meson: Install the marshalers header

The generated marshalers are public API, and the header needs to be
installed, even though nobody should be using them.
Comment 4 Emmanuele Bassi (:ebassi) 2018-04-25 15:37:46 UTC 
Attachment 371388 [details] pushed as e9b4c41 - meson: Install the marshalers header