After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795083 - Pressing the apostrophe key in the text entry field of certain web applications brings up the find bar.
Pressing the apostrophe key in the text entry field of certain web applicatio...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Web Applications
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-08 21:37 UTC by Ryan Farmer
Modified: 2018-04-09 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't search on ' or / (2.85 KB, patch)
2018-04-09 15:53 UTC, Michael Catanzaro
committed Details | Review

Description Ryan Farmer 2018-04-08 21:37:26 UTC
In GNOME Web 3.28. pressing the apostrophe key while typing in the text entry field of certain web applications brings up the find bar.

I've found that this isn't a problem in Gmail as a web app, but it is a problem if you turn Riot.im or Facebook into a web app.

The problem does not occur if using Riot or Facebook within the context of the web browser itself.
Comment 1 Michael Catanzaro 2018-04-08 22:52:15 UTC
I tested out Riot and can reproduce in both app mode and non-app mode. I don't see how app mode could possibly be related, unless perhaps you're running a completely different version of Epiphany for browser mode (e.g. a flatpak?)

I'm thinking the easy solution is to just get rid of this shortcut, but no doubt that means the next bug report will be that the shortcut is gone....
Comment 2 Ryan Farmer 2018-04-09 01:34:02 UTC
In Ubuntu 18.04, this only happens when the site is running as a web app. *shrug* 

As for how Epiphany was installed, it's just a regular Debian package.

Ctrl+F and ' both bring up the find bar. In pretty much every application that has a find bar, Ctrl+F brings it up, so I doubt too many users would be stumped if the ' shortcut went away.
Comment 3 Michael Catanzaro 2018-04-09 15:31:39 UTC
mcatanzaro	Hey KaL, for https://bugzilla.gnome.org/show_bug.cgi?id=795083, can is it OK if I just remove the shortcut, or do you think we should investigate how the event handling is working inside WebKit?
KaL	mcatanzaro: I guess we can just remove the shortcut
mcatanzaro	KaL: Will do
Comment 4 Michael Catanzaro 2018-04-09 15:53:33 UTC
The following fix has been pushed:
543fd1a Don't search on ' or /
Comment 5 Michael Catanzaro 2018-04-09 15:53:36 UTC
Created attachment 370696 [details] [review]
Don't search on ' or /

This causes problems in practice on certain websites (e.g. Facebook,
Riot) where the key press is handled by both the web page and the
browser. I'm guessing these sites are not using normal text entries.
Anyway, these are really niche shortcuts when the much more common
Ctrl+F is available, which does not have any web compat implications.