After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795028 - v4l2transform: set keep_aspect on capture device
v4l2transform: set keep_aspect on capture device
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 795586 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-04-06 13:14 UTC by Guillaume Desmottes
Modified: 2018-04-26 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2transform: set keep_aspect on capture device (1.00 KB, patch)
2018-04-06 13:14 UTC, Guillaume Desmottes 		reviewed Details | Review
v4l2: rely on gst_v4l2_dup() to set no_initial_format and keep_aspect (2.73 KB, patch)
2018-04-13 11:32 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-04-06 13:14:11 UTC 
I think I may have found a typo here.
Comment 1 Guillaume Desmottes 2018-04-06 13:14:29 UTC 
Created attachment 370579 [details] [review]
v4l2transform: set keep_aspect on capture device

Looks like a typo as 'self->v4l2output->keep_aspect = FALSE;' is already
done a few lines above.
Comment 2 Nicolas Dufresne (ndufresne) 2018-04-12 02:57:23 UTC 
Review of attachment 370579 [details] [review]:

Same bug in videodec an videoenc. Maybe we should remove these two, and copy these values in gst_v4l2_dup() (next to never_interlaced boolean).
Comment 3 Guillaume Desmottes 2018-04-13 11:32:24 UTC 
Makes sense yeah.
Comment 4 Guillaume Desmottes 2018-04-13 11:32:45 UTC 
Created attachment 370886 [details] [review]
v4l2: rely on gst_v4l2_dup() to set no_initial_format and keep_aspect

gst_v4l2_dup() will now take care of setting
v4l2capture->no_initial_format and keep_aspect instead of doing it
manually.

Fix a typo as keep_aspect was set twice on v4l2output but never on
v4l2capture.
Comment 5 Nicolas Dufresne (ndufresne) 2018-04-26 19:33:08 UTC 
*** Bug 795586 has been marked as a duplicate of this bug. ***
Comment 6 Nicolas Dufresne (ndufresne) 2018-04-26 19:37:00 UTC 
Attachment 370886 [details] pushed as 2bbe877 - v4l2: rely on gst_v4l2_dup() to set no_initial_format and keep_aspect
Comment 7 Nicolas Dufresne (ndufresne) 2018-04-26 19:38:22 UTC 
And:
commit be9a15a9b26bd86eb69853ac9c85b1d72fe0136c (HEAD -> 1.14, origin/1.14)
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Apr 13 13:29:06 2018 +0200

    v4l2: rely on gst_v4l2_dup() to set no_initial_format and keep_aspect
    
    gst_v4l2_dup() will now take care of setting
    v4l2capture->no_initial_format and keep_aspect instead of doing it
    manually.
    
    Fix a typo as keep_aspect was set twice on v4l2output but never on
    v4l2capture.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795028