After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794674 - Allow the user to specify a connection is capped/metered from GUI
Allow the user to specify a connection is capped/metered from GUI
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-connection-editor
unspecified
Other Linux
: Normal minor
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2018-03-25 15:58 UTC by mirh
Modified: 2018-03-28 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH 1/2] editor: improve layout of general page (9.66 KB, patch)
2018-03-27 07:46 UTC, Beniamino Galvani
none Details | Review
[PATCH 2/2] editor: support the connection.metered property (4.55 KB, patch)
2018-03-27 07:46 UTC, Beniamino Galvani
none Details | Review

Description mirh 2018-03-25 15:58:02 UTC
Follows bug 745747, except it should be a pretty core capability of nm imo (rather than just inside GNOME settings)
Comment 1 Beniamino Galvani 2018-03-27 07:46:10 UTC
Created attachment 370173 [details] [review]
[PATCH 1/2] editor: improve layout of general page
Comment 2 Beniamino Galvani 2018-03-27 07:46:29 UTC
Created attachment 370174 [details] [review]
[PATCH 2/2] editor: support the connection.metered property
Comment 3 Thomas Haller 2018-03-27 08:35:10 UTC
lgtm
Comment 4 mirh 2018-03-27 22:11:41 UTC
Tested. And nicely executed imo. 
(kinda strange I get "automatic" translated, while "yes" remains in english)
Comment 5 Beniamino Galvani 2018-03-28 07:04:00 UTC
Applied:

b40d53bc0394c69db01b0d15f765372bf9cd67fd
0232c93cd2361db281b745690afe3423097bacfc