After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794566 - Generated code does not compile when file-descriptor-passing is used
Generated code does not compile when file-descriptor-passing is used
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
0.41.x
Other All
: Normal critical
: 0.42
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-21 15:07 UTC by Ole André Vadla Ravnås
Modified: 2018-03-28 06:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdbus: Add missing GUnixFDList variable declaration (956 bytes, patch)
2018-03-21 15:08 UTC, Ole André Vadla Ravnås
none Details | Review
gdbus: Fix missing declaration of _fd_list for async methods (4.57 KB, patch)
2018-03-27 22:14 UTC, Rico Tzschichholz
committed Details | Review

Description Ole André Vadla Ravnås 2018-03-21 15:07:34 UTC
The generated code references a variable named `_fd_list` without declaring it first.
Comment 1 Ole André Vadla Ravnås 2018-03-21 15:08:30 UTC
Created attachment 369966 [details] [review]
gdbus: Add missing GUnixFDList variable declaration
Comment 2 Rico Tzschichholz 2018-03-21 15:40:07 UTC
Could you add a test-case which triggers this problem?
Comment 3 Rico Tzschichholz 2018-03-22 14:54:55 UTC
Just for completeness, the test-suite failures with this patch:

tests/_test/main.c: In function ‘dbus_enum_string_marshalling_test_proxy_test3’:
tests/_test/main.c:85010:15: error: redeclaration of ‘_fd_list’ with no linkage
  GUnixFDList* _fd_list;
               ^~~~~~~~
tests/_test/main.c:85007:15: note: previous declaration of ‘_fd_list’ was here
  GUnixFDList *_fd_list;
               ^~~~~~~~
tests/_test/main.c: In function ‘dbus_filedescriptor_client_test_proxy_test_in’:
tests/_test/main.c:86139:15: error: redeclaration of ‘_fd_list’ with no linkage
  GUnixFDList* _fd_list;
               ^~~~~~~~
tests/_test/main.c:86136:15: note: previous declaration of ‘_fd_list’ was here
  GUnixFDList *_fd_list;
               ^~~~~~~~
tests/_test/main.c: In function ‘dbus_filedescriptor_errors_client_test_proxy_test’:
tests/_test/main.c:87023:15: error: redeclaration of ‘_fd_list’ with no linkage
  GUnixFDList* _fd_list;
               ^~~~~~~~
tests/_test/main.c:87020:15: note: previous declaration of ‘_fd_list’ was here
  GUnixFDList *_fd_list;
               ^~~~~~~~
Comment 4 Rico Tzschichholz 2018-03-27 22:14:09 UTC
Created attachment 370220 [details] [review]
gdbus: Fix missing declaration of _fd_list for async methods
Comment 5 Rico Tzschichholz 2018-03-28 06:42:12 UTC
Attachment 370220 [details] pushed as 724397a - gdbus: Fix missing declaration of _fd_list for async methods