After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794533 - v4l2: Fix unknown type name ‘off_t’ error
v4l2: Fix unknown type name ‘off_t’ error
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-20 15:28 UTC by Seungha Yang
Modified: 2018-03-27 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2: Fix unknown type name ‘off_t’ error (1.29 KB, patch)
2018-03-20 15:30 UTC, Seungha Yang 		none Details | Review
v4l2: Fix unknown type name ‘off_t’ error (1.35 KB, patch)
2018-03-21 01:39 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2018-03-20 15:28:40 UTC 
Fix following build error

gstv4l2object.h:197:17: error: unknown type name ‘off_t’
       gint fd,  off_t offset);
                 ^
Comment 1 Seungha Yang 2018-03-20 15:30:49 UTC 
Created attachment 369916 [details] [review]
v4l2: Fix unknown type name ‘off_t’ error

Fix build error on WSL environment
Comment 2 Nicolas Dufresne (ndufresne) 2018-03-20 17:11:22 UTC 
Review of attachment 369916 [details] [review]:

::: sys/v4l2/gstv4l2object.h
@@ +30,3 @@
 #endif
 
+#ifdef HAVE_UNISTD_H

Seems fair change, though isn't unistd strictly required deps, which would mean we don't need this ifdef.
Comment 3 Seungha Yang 2018-03-21 01:39:06 UTC 
Created attachment 369937 [details] [review]
v4l2: Fix unknown type name ‘off_t’ error

I update patch to include unistd without ifdef.
Comment 4 Nicolas Dufresne (ndufresne) 2018-03-21 03:20:25 UTC 
Review of attachment 369937 [details] [review]:

Thanks, that will be merged soon.
Comment 5 Nicolas Dufresne (ndufresne) 2018-03-27 17:47:58 UTC 
Attachment 369937 [details] pushed as c4d1368 - v4l2: Fix unknown type name ‘off_t’ error
Comment 6 Nicolas Dufresne (ndufresne) 2018-03-27 17:59:25 UTC 
Commited to 1.14 as 6ab0442f90520c6cc1c076b0a0d22af534b274ec